From: Clemens Buchacher <drizzd@aon.at>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Marc Branchaud" <marcnarc@xiplink.com>,
git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"David Aguilar" <davvid@gmail.com>,
"Carlos Martín Nieto" <cmn@elego.de>,
"Martin von Zweigbergk" <martin.von.zweigbergk@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH/RFC] remove #!interpreter line from shell libraries
Date: Tue, 13 Mar 2012 20:09:49 +0100 [thread overview]
Message-ID: <20120313190949.GB8074@ecki> (raw)
In-Reply-To: <20120312191703.GB21817@burratino>
On Mon, Mar 12, 2012 at 02:17:03PM -0500, Jonathan Nieder wrote:
>
> By the way, my mild dislike for the #! line in shell libraries is
> actually rooted in functionality, in a way. Though it would never
> happen in git, I have had too many unhappy experiences of shell
> libraries with #!/bin/bash at the top that were used in #!/bin/sh
> scripts and broke completely. So that is where the bad association
> comes from.
Maybe I am missing something here, but as far as I can see this is an
argument for _keeping_ the #! line, because at least it will give a hint
that a /bin/bash library will not work for a /bin/sh script, whereas
"this is a shell library" can mean almost anything.
Anyways, I can certainly survive without the #! line. So please feel
free to ignore my comments if you feel strongly about this.
Clemens
next prev parent reply other threads:[~2012-03-13 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 12:14 [PATCH/RFC] remove #!interpreter line from shell libraries Jonathan Nieder
2012-03-08 12:47 ` Jeff King
2012-03-09 7:58 ` Clemens Buchacher
2012-03-12 18:53 ` Marc Branchaud
2012-03-12 19:17 ` Jonathan Nieder
2012-03-13 19:09 ` Clemens Buchacher [this message]
2012-03-12 19:50 ` Junio C Hamano
2012-03-12 21:38 ` Clemens Buchacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313190949.GB8074@ecki \
--to=drizzd@aon.at \
--cc=avarab@gmail.com \
--cc=cmn@elego.de \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=marcnarc@xiplink.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).