From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Tay Ray Chuan <rctay89@gmail.com>,
Michal Privoznik <mprivozn@redhat.com>,
git@vger.kernel.org, trast@student.ethz.ch,
Lawrence.Holding@cubic.com
Subject: Re: [PATCH] diff: Introduce diff.algorithm variable
Date: Tue, 13 Mar 2012 16:48:26 -0400 [thread overview]
Message-ID: <20120313204826.GA27436@sigill.intra.peff.net> (raw)
In-Reply-To: <7v399cxuk9.fsf@alter.siamese.dyndns.org>
On Tue, Mar 13, 2012 at 10:46:46AM -0700, Junio C Hamano wrote:
> Tay Ray Chuan <rctay89@gmail.com> writes:
>
> > Considering that --minimal isn't really an algorithm,...
>
> I think this discussion thread already settled that "minimal" *is* an
> algorithm for the purpose of this topic, considering that the --minimal
> option does not apply anything but myers.
I don't know that it is settled. I proposed it as a concept, and nobody
else objected. It is true that right _now_ --minimal doesn't do anything
for non-myers algorithms, but in theory it could. IOW, it is a matter of
the user's perspective whether the flag is "use the minimal Myers diff
algorithm" versus "spend extra effort to make the diff more minimal, no
matter which algorithm is being used". If the latter, it is only that we
have not (yet) implemented the extra effort tweaks to the other
algorithms.
So I think we could go either way.
-Peff
prev parent reply other threads:[~2012-03-13 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 13:48 [PATCH] diff: Introduce diff.algorithm variable Michal Privoznik
2012-03-09 18:40 ` Junio C Hamano
2012-03-12 5:42 ` Junio C Hamano
2012-03-13 14:42 ` Tay Ray Chuan
2012-03-13 17:46 ` Junio C Hamano
2012-03-13 20:48 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313204826.GA27436@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Lawrence.Holding@cubic.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mprivozn@redhat.com \
--cc=rctay89@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).