From: Jeff King <peff@peff.net>
To: 김남형 <namhyung.kim@lge.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/3] help: Fix help message for aliases
Date: Thu, 15 Mar 2012 09:19:04 -0400 [thread overview]
Message-ID: <20120315131903.GA8467@sigill.intra.peff.net> (raw)
In-Reply-To: <4F617AE2.9050700@lge.com>
On Thu, Mar 15, 2012 at 02:15:14PM +0900, 김남형 wrote:
> >What output does this produce for:
> >
> > $ git config alias.foo '!f() { git log $1@{u}..$1; }; f'
> > $ git help foo
> >
> >?
> >
>
> Oh, I didn't think of such a complicated case. Hmm, how about
> checking whether the first word is a git command or not:
>
> printf("`git %s' is aliased to `%s%s'\n", argv[0],
> is_git_command(first_word) ? "git " : "", alias);
I think the right solution is to just look for "!", which is what tells
git it is a shell command.
-Peff
next prev parent reply other threads:[~2012-03-15 13:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 2:52 [PATCH 1/3] help: Fix help message for aliases Namhyung Kim
2012-03-15 2:52 ` [PATCH 2/3] help: Add '--follow-alias' option Namhyung Kim
2012-03-15 6:00 ` Junio C Hamano
2012-03-15 6:15 ` 김남형
2012-03-15 6:23 ` Junio C Hamano
2012-03-15 6:46 ` Namhyung Kim
2012-03-15 7:09 ` Junio C Hamano
2012-03-15 2:52 ` [PATCH 3/3] help: Add 'help.follow-alias' config item Namhyung Kim
2012-03-15 6:06 ` Junio C Hamano
2012-03-15 6:29 ` Namhyung Kim
2012-03-15 4:17 ` [PATCH 1/3] help: Fix help message for aliases Jeff King
2012-03-15 5:15 ` 김남형
2012-03-15 13:19 ` Jeff King [this message]
2012-03-15 5:23 ` Junio C Hamano
2012-03-15 5:48 ` 김남형
2012-03-15 6:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315131903.GA8467@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=namhyung.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).