From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
git@vger.kernel.org, "Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v2 1/2] t0303: immediately bail out w/o GIT_TEST_CREDENTIAL_HELPER
Date: Thu, 15 Mar 2012 09:26:43 -0400 [thread overview]
Message-ID: <20120315132642.GA8945@sigill.intra.peff.net> (raw)
In-Reply-To: <20120315132428.GB8467@sigill.intra.peff.net>
On Thu, Mar 15, 2012 at 09:24:28AM -0400, Jeff King wrote:
> > >> make GIT_TEST_CREDENTIAL_HELPER=cache T=t0303-*.sh prove
> > >>
> > >> seems to get stuck forever.
> > >
> > > It's because t0303 is the generic "test any helper" script, and does not
> > > know how to clean up the credential-cache daemon. So the daemon sticks
> > > around, holding onto a file descriptor that causes prove to hang.
> >
> > And the reason why "sh t0303-*.sh" version does not have this problem is...?
> [long-winded explanation from me]
Oops. I read this as "why does t0301 not have the problem?". So ignore
everything I said.
The reason why running it via sh works is that we leave the daemon
running in both cases, but only prove actually cares about the leaked
file descriptor and blocks.
-Peff
next prev parent reply other threads:[~2012-03-15 13:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 12:05 [PATCH 0/2] prettify t0303-credential-helpers.sh Zbigniew Jędrzejewski-Szmek
2012-03-12 12:05 ` [PATCH 1/2] t0303: set reason for skipping tests Zbigniew Jędrzejewski-Szmek
2012-03-12 12:30 ` Jeff King
2012-03-12 21:07 ` Zbigniew Jędrzejewski-Szmek
2012-03-13 21:53 ` Jeff King
2012-03-14 14:14 ` Zbigniew Jędrzejewski-Szmek
2012-03-14 14:18 ` [PATCH v2 1/2] t0303: immediately bail out w/o GIT_TEST_CREDENTIAL_HELPER Zbigniew Jędrzejewski-Szmek
2012-03-14 14:18 ` [PATCH v2 2/2] t0303: resurrect commit message as test documentation Zbigniew Jędrzejewski-Szmek
2012-03-14 22:17 ` [PATCH v2 1/2] t0303: immediately bail out w/o GIT_TEST_CREDENTIAL_HELPER Junio C Hamano
2012-03-15 3:54 ` Jeff King
2012-03-15 6:55 ` Junio C Hamano
2012-03-15 10:44 ` Zbigniew Jędrzejewski-Szmek
2012-03-15 11:08 ` [PATCH v3 " Zbigniew Jędrzejewski-Szmek
2012-03-15 11:08 ` [PATCH v3 2/2] t0303: resurrect commit message as test documentation Zbigniew Jędrzejewski-Szmek
2012-03-15 17:51 ` [PATCH v3 1/2] t0303: immediately bail out w/o GIT_TEST_CREDENTIAL_HELPER Junio C Hamano
2012-03-15 13:24 ` [PATCH v2 " Jeff King
2012-03-15 13:26 ` Jeff King [this message]
2012-03-15 17:50 ` Junio C Hamano
2012-03-15 3:56 ` Jeff King
2012-03-12 12:05 ` [PATCH 2/2] t0303: resurrect commit message as test documentation Zbigniew Jędrzejewski-Szmek
2012-03-12 12:31 ` Jeff King
2012-03-12 20:43 ` Jonathan Nieder
2012-03-13 21:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315132642.GA8945@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).