From: Bryan Jacobs <bjacobs@woti.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: Avishay Lavie <avishay.lavie@gmail.com>,
git@vger.kernel.org, Sam Vilain <sam@vilain.net>
Subject: Re: [PATCH] git svn dcommit: avoid self-referential mergeinfo lines when svn.pushmergeinfo is configured
Date: Thu, 15 Mar 2012 18:07:03 -0400 [thread overview]
Message-ID: <20120315180703.7c9c0629@robyn.woti.com> (raw)
In-Reply-To: <20120315220242.GA9348@dcvr.yhbt.net>
On Thu, 15 Mar 2012 22:02:42 +0000
Eric Wong <normalperson@yhbt.net> wrote:
>
> This test breaks t9161-git-svn-mergeinfo-push.sh:
>
> not ok - 12 check reintegration mergeinfo
> #
> # mergeinfo=$(svn_cmd propget svn:mergeinfo
> "$svnrepo"/branches/svnb4) # test "$mergeinfo" =
> "/branches/svnb1:2-4,7-9,13-18 # /branches/svnb2:3,8,16-17
> # /branches/svnb3:4,9
> # /branches/svnb4:5-6,10-12
> # /branches/svnb5:6,11"
>
> Be sure tests run successfully before submitting patches (or ask
> for help fixing tests).
The test is demonstrating the behavior the patch fixes.
A merge is made to "svnb4", and then the test checks that the mergeinfo
contains "svnb4:5-6,10-12". So really this test could be adapted to
prove that the patch is functioning as intended :-).
Bryan Jacobs
next prev parent reply other threads:[~2012-03-15 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 16:09 [PATCH] git svn dcommit: avoid self-referential mergeinfo lines when svn.pushmergeinfo is configured Avishay Lavie
2012-03-14 16:15 ` Bryan Jacobs
2012-03-14 16:23 ` Thomas Rast
2012-03-15 22:02 ` Eric Wong
2012-03-15 22:07 ` Bryan Jacobs [this message]
2012-03-15 22:28 ` [spf:guess] " Sam Vilain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315180703.7c9c0629@robyn.woti.com \
--to=bjacobs@woti.com \
--cc=avishay.lavie@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).