From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Thomas Rast <trast@student.ethz.ch>,
PJ Weisberg <pj@irregularexpressions.net>,
git@vger.kernel.org
Subject: Re: [PATCH] Demonstrate failure of 'core.ignorecase = true'
Date: Fri, 23 Mar 2012 14:48:44 -0400 [thread overview]
Message-ID: <20120323184823.GA14711@sigill.intra.peff.net> (raw)
In-Reply-To: <7v62dvus3f.fsf@alter.siamese.dyndns.org>
On Fri, Mar 23, 2012 at 10:47:48AM -0700, Junio C Hamano wrote:
> Thomas Rast <trast@student.ethz.ch> writes:
>
> > How about trying to read "HEAD" as "head" instead when core.ignorecase
> > is true? That would allow us to catch such misconfiguration (which I
> > imagine can also happen accidentally if you mv a repository across FS
> > boundaries) and tell the user about it.
>
> Do you mean something like this?
>
> I do not like it. It essentially amounts to checking with the FS every
> time we run Git.
I think Thomas's suggestion is to piggy-back it onto an existing file
lookup ("head" instead of "HEAD"), so you aren't doing any extra work.
However, I'm not sure that would be sufficient. If I copy a repo from a
case-insensitive filesystem to a case-sensitive one, what will the case
of "HEAD" be on the new filesystem?
If the original filesystem was case-preserving, I would expect "HEAD".
But on a true caseless filesystem, it could be either. Of course,
current git would already blow up if the file was copied as "head",
which makes me think this is probably a rare case. So maybe that is not
worth worrying about.
I dunno. I think Thomas's idea is clever, but is this actually a problem
in practice? The current discussion seems more like a documentation bug,
and I don't remember seeing anybody reporting issues moving a repo
across filesystems (presumably most people use clone or push, which
handle this properly).
-Peff
next prev parent reply other threads:[~2012-03-23 18:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 22:50 [PATCH] Demonstrate failure of 'core.ignorecase = true' Peter J. Weisberg
2012-03-21 23:58 ` Junio C Hamano
2012-03-22 20:40 ` PJ Weisberg
2012-03-22 21:08 ` Junio C Hamano
2012-03-23 10:20 ` Thomas Rast
2012-03-23 17:47 ` Junio C Hamano
2012-03-23 18:48 ` Jeff King [this message]
2012-03-23 18:57 ` Jeff King
2012-03-22 6:49 ` Johannes Sixt
2012-03-22 11:25 ` Zbigniew Jędrzejewski-Szmek
2012-03-22 14:12 ` Jeff King
2012-03-22 16:57 ` Junio C Hamano
2012-03-22 17:37 ` Jeff King
2012-03-22 18:44 ` Junio C Hamano
2012-03-22 19:07 ` Jeff King
2012-03-22 20:33 ` Junio C Hamano
2012-03-22 20:00 ` Zbigniew Jędrzejewski-Szmek
2012-03-22 20:37 ` Junio C Hamano
2012-03-22 20:53 ` Zbigniew Jędrzejewski-Szmek
2012-03-22 20:55 ` PJ Weisberg
2012-03-22 21:09 ` Junio C Hamano
2012-03-22 23:00 ` Jeff King
2012-03-22 23:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323184823.GA14711@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pj@irregularexpressions.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).