From: Christopher Tiwald <christiwald@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, gitster@pobox.com, zbyszek@in.waw.pl,
Matthieu.Moy@grenoble-inp.fr, drizzd@aon.at
Subject: Re: [PATCH v3] push: Provide situational hints for non-fast-forward errors
Date: Mon, 26 Mar 2012 15:57:43 -0400 [thread overview]
Message-ID: <20120326195743.GD32387@gmail.com> (raw)
In-Reply-To: <20120326195150.GA13098@sigill.intra.peff.net>
On Mon, Mar 26, 2012 at 03:51:50PM -0400, Jeff King wrote:
> On Mon, Mar 26, 2012 at 03:20:01PM -0400, Christopher Tiwald wrote:
>
> > I used the REF_STATUS_* enum as a template for what I wanted to accomplish
> > when authoring v1, but did notice there was no other place my new
> > options made much sense (Junio helped me remove one other call between v1
> > and v2). I like the readability fixup, but it won't compile as both push.c
> > and transport.c need to see these. Would something like the following
> > work? It simply moves the define statements to cache.h, so that both push and
> > transport can use them.
>
> My suggestion put them in transport.h, which is included from both
> places. It compiles fine for me. Am I missing something?
Ah nope. That was me. Sorry about the noise. This otherwise makes sense
to me.
--
Christopher Tiwald
next prev parent reply other threads:[~2012-03-26 19:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 4:31 [PATCH v3] push: Provide situational hints for non-fast-forward errors Christopher Tiwald
2012-03-20 5:47 ` Junio C Hamano
2012-03-23 21:41 ` Jeff King
2012-03-26 19:20 ` Christopher Tiwald
2012-03-26 19:51 ` Jeff King
2012-03-26 19:57 ` Christopher Tiwald [this message]
2012-03-26 20:00 ` Jeff King
2012-03-26 20:05 ` Junio C Hamano
2012-03-26 20:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326195743.GD32387@gmail.com \
--to=christiwald@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).