From: Jakub Narebski <jnareb@gmail.com>
To: "W. Trevor King" <wking@drexel.edu>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v4 0/3] Isolate If-Modified-Since handling in gitweb
Date: Tue, 27 Mar 2012 20:24:22 +0100 [thread overview]
Message-ID: <201203272124.23145.jnareb@gmail.com> (raw)
In-Reply-To: <20120326110943.GA2951@odin.tremily.us>
On Mon, 26 Mar 2012, W. Trevor King wrote:
> Sorry for the delay since my last message, it's been a busy week ;).
Thanks for working on this topic.
BTW. we are in feature freeze currently, before release of v1.7.10.
> I'll be sending along three patches. [...]
> [...] The first is a teensy patch to add `Status`
> output to non-304 calls to git_feed(). Without it you'd have to get a
> bit more creative in the test suite. If the status lines were left
> out intentionally, let me know, and I'll come up with another
> condition for those tests.
No, the status line was omitted unintentionally, thanks for fixing this.
I guess that web server (at least Apache) adds it if it is missing.
Though I am not sure how lack of "Status:" header is different from
incorrect "Status:" header for 'grep "Status: 304" gitweb.headers'...
> The second patch refactors and tests git_feed(), and the third patch
> adds i-m-s support to git_snapshot() with associated tests.
>
> Changes since v3:
> * Patch 1/3 is completely new.
> * Split previous patch into 2/3 and 3/3.
> * Conditionals in 3/3 to avoid 404-ing on non-commits like v1.7.6^{tree}.
> * Added testing to both 2/3 and 3/3.
> * Reworked commit messages.
Good.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2012-03-27 19:24 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 0:23 What's cooking in git.git (Mar 2012, #07; Mon, 19) Junio C Hamano
2012-03-15 7:54 ` [PATCH] Pull gitweb If-Modified-Since handling out into its own function and use for snapshots W. Trevor King
2012-03-20 1:48 ` W. Trevor King
2012-03-20 23:07 ` Junio C Hamano
2012-03-20 11:55 ` Jakub Narebski
2012-03-20 16:40 ` [PATCH v2] " W. Trevor King
2012-03-21 12:11 ` [PATCH v3] Isolate If-Modified-Since handling in gitweb W. Trevor King
2012-03-21 13:19 ` Jakub Narebski
2012-03-21 14:04 ` W. Trevor King
2012-03-21 16:55 ` Jakub Narebski
2012-03-21 17:38 ` W. Trevor King
2012-03-21 19:22 ` Junio C Hamano
2012-03-21 19:55 ` W. Trevor King
2012-03-21 20:04 ` Jakub Narebski
2012-03-21 20:09 ` Junio C Hamano
2012-03-21 20:34 ` W. Trevor King
2012-03-22 13:05 ` Jakub Narebski
2012-03-21 17:21 ` Junio C Hamano
2012-03-22 12:46 ` Jakub Narebski
2012-03-22 17:00 ` Junio C Hamano
2012-03-26 11:09 ` [PATCH v4 0/3] " W. Trevor King
2012-03-26 11:11 ` [PATCH v4 1/3] gitweb: add `status` headers to git_feed() responses W. Trevor King
2012-03-26 11:12 ` [PATCH v4 2/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-26 17:12 ` Junio C Hamano
2012-03-26 11:13 ` [PATCH v4 3/3] gitweb: add If-Modified-Since handling to git_snapshot() W. Trevor King
2012-03-26 19:14 ` [PATCH v5 " W. Trevor King
2012-03-27 22:31 ` Jakub Narebski
2012-03-28 13:58 ` W. Trevor King
2012-03-27 19:24 ` Jakub Narebski [this message]
2012-03-27 19:49 ` [PATCH v4 0/3] Isolate If-Modified-Since handling in gitweb W. Trevor King
2012-03-27 19:57 ` Jakub Narebski
2012-03-27 19:55 ` W. Trevor King
2012-03-27 20:18 ` Junio C Hamano
2012-03-26 17:36 ` [PATCH v4 2/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-26 18:39 ` Junio C Hamano
2012-03-26 19:12 ` [PATCH v5 " W. Trevor King
2012-03-27 22:24 ` Jakub Narebski
2012-03-28 13:51 ` W. Trevor King
2012-03-28 14:13 ` Jakub Narebski
2012-03-28 15:46 ` [PATCH v6 0/3] " wking
2012-03-28 15:46 ` [PATCH v6 1/3] gitweb: add `status` headers to git_feed() responses wking
2012-03-28 15:47 ` [PATCH v6 2/3] gitweb: refactor If-Modified-Since handling wking
2012-03-28 15:47 ` [PATCH v6 3/3] gitweb: add If-Modified-Since handling to git_snapshot() wking
2012-03-28 16:08 ` Jakub Narebski
2012-03-28 15:56 ` [PATCH v6 0/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-20 23:35 ` Incremental updates to What's cooking Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203272124.23145.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wking@drexel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).