From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH 2/2] git: continue alias lookup on EACCES errors Date: Wed, 28 Mar 2012 15:39:09 -0400 Message-ID: <20120328193909.GB29019@sigill.intra.peff.net> References: <20120327175933.GA1716@sigill.intra.peff.net> <20120327180503.GB4659@sigill.intra.peff.net> <7v4nt9j1m3.fsf@alter.siamese.dyndns.org> <20120328043058.GD30251@sigill.intra.peff.net> <7vaa30wrjx.fsf@alter.siamese.dyndns.org> <20120328174841.GA27876@sigill.intra.peff.net> <20120328180404.GA9052@burratino> <7v1uocwpap.fsf@alter.siamese.dyndns.org> <20120328184014.GA8982@burratino> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Junio C Hamano , James Pickens , Git ML To: Jonathan Nieder X-From: git-owner@vger.kernel.org Wed Mar 28 21:39:18 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SCyiD-0008DX-V2 for gcvg-git-2@plane.gmane.org; Wed, 28 Mar 2012 21:39:18 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758220Ab2C1TjN (ORCPT ); Wed, 28 Mar 2012 15:39:13 -0400 Received: from 99-108-226-0.lightspeed.iplsin.sbcglobal.net ([99.108.226.0]:36276 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758027Ab2C1TjL (ORCPT ); Wed, 28 Mar 2012 15:39:11 -0400 Received: (qmail 20587 invoked by uid 107); 28 Mar 2012 19:39:30 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Wed, 28 Mar 2012 15:39:30 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 28 Mar 2012 15:39:09 -0400 Content-Disposition: inline In-Reply-To: <20120328184014.GA8982@burratino> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Mar 28, 2012 at 01:40:14PM -0500, Jonathan Nieder wrote: > On Wed, Mar 28, 2012 at 11:31:10AM -0700, Junio C Hamano wrote: > > Jonathan Nieder writes: > > >> Example: when I try > >> > >> :; mkdir $HOME/cannotread > >> :; chmod -x $HOME/cannotread > >> :; echo nonsense >$HOME/bin/cat > >> :; chmod -x $HOME/bin/cat > >> :; PATH=$HOME/cannotread:$HOME/bin:/usr/local/bin:/usr/bin:/bin > >> :; cat /etc/fstab > >> > >> the shell uses /bin/cat without complaint. > > > > Yeah, but I think that the case Peff is worried about is: > > > > $ >~/bin/nosuch > > $ nosuch > > nosuch: Permission denied > > Just remembering the EACCES and reporting it when no alias exists > would take care of that, no? In other words, this seems analogous > to the example of a non-executable "cat" that is reported if no > other cat exists but does not prevent /bin/cat from being run. That's what the patch I posted earlier does. But it means we _also_ report "permission denied" for inaccessible directories, which is needlessly confusing (and much more common, I would think). -Peff