git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ben Walton <bwalton@artsci.utoronto.ca>,
	peff@peff.net, j.sixt@viscovery.net, git@vger.kernel.org
Subject: Re: [PATCH] Use SHELL_PATH from build system in run_command.c:prepare_shell_cmd
Date: Thu, 29 Mar 2012 01:09:36 -0500	[thread overview]
Message-ID: <20120329060936.GB2026@burratino> (raw)
In-Reply-To: <7v8vikrr5l.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> Ben Walton <bwalton@artsci.utoronto.ca> writes:

>> Possible fixes for this issue are:
>> ...
>> 2. The git wrapper could prepend SANE_TOOL_PATH to PATH for
>>    consistency with builtin commands.
>>
>> 3. The run_command.c:prepare_shell_command() could use the same
>>    SHELL_PATH that is in the #! line of all all scripts.
>> ...
>> Option 2 is voided by the same example that turned up this issue.
>> SANE_TOOL_PATH might also include 'insane' tools.
[...]
> This line of reasoning makes me feel uneasy.

I think the missing detail in the above explanation is that "sh" is a
special case.  Even though POSIX and good sense would require "sh" to
name a reasonable shell just like "grep" needs to name a reasonable
grep, on Solaris we have never been able to count on an "sh" for git's
needs and common practice seems to be to give up and just use bash or
ksh.

See v1.5.5-rc0~5^2~3 (filter-branch: use $SHELL_PATH instead of 'sh',
2008-03-12), for example.

  reply	other threads:[~2012-03-29  6:10 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-25 12:31 [PATCH 0/2] Make run-command.c honour SHELL_PATH Ben Walton
2012-03-25 12:31 ` [PATCH 1/2] run-command.c: Define SHELL_PATH macro for use in prepare_shell_cmd Ben Walton
2012-03-25 12:31 ` [PATCH 2/2] Makefile: Set EXTRA_CPPFLAGS during the compilation of run-command Ben Walton
2012-03-26  1:11 ` [PATCH 0/2] Make run-command.c honour SHELL_PATH Jonathan Nieder
2012-03-26 13:38   ` Ben Walton
2012-03-26 18:12     ` Jeff King
2012-03-26 18:19       ` Ben Walton
2012-03-26 18:24         ` Jeff King
2012-03-27  2:41           ` [PATCH] Use SHELL_PATH to fork commands in run_command.c:prepare_shell_cmd Ben Walton
2012-03-27  3:29             ` Jeff King
2012-03-27  3:34               ` Jeff King
2012-03-27  5:01               ` Jonathan Nieder
2012-03-27  5:12                 ` Jeff King
2012-03-27  5:53                   ` Jonathan Nieder
2012-03-27  6:23               ` Johannes Sixt
2012-03-28  2:46               ` Ben Walton
2012-03-28  4:22                 ` Jeff King
2012-03-28 23:26                   ` [PATCH] Use SHELL_PATH from build system " Ben Walton
2012-03-29  4:02                     ` Junio C Hamano
2012-03-29  6:09                       ` Jonathan Nieder [this message]
     [not found]                       ` <1333073831-sup-5734@pinkfloyd.chass.utoronto.ca>
2012-03-30  6:32                         ` Jonathan Nieder
2012-03-29 23:00                     ` Jonathan Nieder
2012-03-28 23:28                   ` [PATCH] Use SHELL_PATH to fork commands " Ben Walton
2012-03-27  4:26             ` Jonathan Nieder
2012-03-27  4:49               ` Jonathan Nieder
2012-03-27  2:45           ` [PATCH 0/2] Make run-command.c honour SHELL_PATH Ben Walton
2012-03-26 18:17     ` Jonathan Nieder
2012-03-26 18:08   ` Jeff King
2012-03-26 17:58 ` Jeff King
     [not found] <7vvclmoit6.fsf@alter.siamese.dyndns.org>
2012-03-31  1:33 ` [PATCH] Use SHELL_PATH from build system in run_command.c:prepare_shell_cmd Ben Walton
2012-03-31  3:48   ` Jonathan Nieder
2012-03-31  5:38     ` Junio C Hamano
2012-03-31  5:55   ` Jonathan Nieder
2012-03-31 17:49     ` Junio C Hamano
2012-03-31 18:04       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120329060936.GB2026@burratino \
    --to=jrnieder@gmail.com \
    --cc=bwalton@artsci.utoronto.ca \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).