From: Jeff King <peff@peff.net>
To: Victor Engmark <victor.engmark@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH] Add diff.minimal configuration setting
Date: Fri, 30 Mar 2012 04:09:04 -0400 [thread overview]
Message-ID: <20120330080904.GA2661@sigill.intra.peff.net> (raw)
In-Reply-To: <20120329202648.GA27318@l0b0x>
On Thu, Mar 29, 2012 at 10:26:48PM +0200, Victor Engmark wrote:
> Complements the --minimal and --no-minimal options.
There was a recent discussion here:
http://article.gmane.org/gmane.comp.version-control.git/192719
where two similar options were considered:
1. diff.algorithm should be added, and consider "minimal" to be a
variant algorithm
2. we should have a generic "diff options" config variable, in which
one could put "--minimal", "--patience", or whatever.
I don't think anything was decided, but either option would remove the
need for a separate diff.minimal variable. Maybe it would be worth
combining efforts.
-Peff
PS I like the generality of (2), but the idea of diff defaults came up a
few years ago, and I remember it devolving into quite a complex
patch. But that may also just have been the patch submitter, who
seemed very interested in complexifying things. I can dig up the
discussion if you want.
prev parent reply other threads:[~2012-03-30 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 20:26 [PATCH] Add diff.minimal configuration setting Victor Engmark
2012-03-30 8:09 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120330080904.GA2661@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
--cc=victor.engmark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).