From: Jakub Narebski <jnareb@gmail.com>
To: "W. Trevor King" <wking@drexel.edu>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v8 2/3] gitweb: refactor If-Modified-Since handling
Date: Fri, 30 Mar 2012 16:30:51 +0100 [thread overview]
Message-ID: <201203301730.52615.jnareb@gmail.com> (raw)
In-Reply-To: <8839345a047a7dee825565032029b1c08890a0f0.1333024238.git.wking@drexel.edu>
W. Trevor King wrote:
> The current gitweb only generates Last-Modified and handles
> If-Modified-Since headers for the git_feed action. This patch breaks
> the Last-Modified and If-Modified-Since handling code out from
> git_feed into a new function exit_if_unmodified_since. This makes the
> code easy to reuse for other actions.
>
> Only gitweb actions which can easily calculate a modification time
> should use exit_if_unmodified_since, as the goal is to balance local
> processing time vs. upload bandwidth.
>
> Signed-off-by: W Trevor King <wking@drexel.edu>
Nice and clear.
Acked-by: Jakub Narebski <jnareb@gmail.com>
Perhaps the second paragraph of the commit message would read better if
it started with "Note that only ..." or something like that, but this
is not that important, and not worth another round.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2012-03-30 15:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120328164513.GA4389@odin.tremily.us>
2012-03-28 17:44 ` [PATCH v7 0/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-28 17:44 ` [PATCH v7 1/3] gitweb: add `status` headers to git_feed() responses W. Trevor King
2012-03-28 17:44 ` [PATCH v7 2/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-28 17:44 ` [PATCH v7 3/3] gitweb: add If-Modified-Since handling to git_snapshot() W. Trevor King
2012-03-28 18:11 ` Jakub Narebski
2012-03-28 18:37 ` W. Trevor King
2012-03-28 19:11 ` Junio C Hamano
2012-03-28 19:27 ` W. Trevor King
2012-03-28 21:45 ` Jakub Narebski
2012-03-28 21:28 ` Jakub Narebski
2012-03-29 12:45 ` [PATCH v8 0/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-29 12:45 ` [PATCH v8 1/3] gitweb: add `status` headers to git_feed() responses W. Trevor King
2012-03-30 15:21 ` Jakub Narebski
2012-03-29 12:45 ` [PATCH v8 2/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-30 15:30 ` Jakub Narebski [this message]
2012-03-29 12:45 ` [PATCH v8 3/3] gitweb: add If-Modified-Since handling to git_snapshot() W. Trevor King
2012-03-30 16:07 ` Jakub Narebski
2012-03-30 16:11 ` [PATCH v8 0/3] gitweb: refactor If-Modified-Since handling Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203301730.52615.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wking@drexel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).