From: Jeff King <peff@peff.net>
To: Ivan Todoroski <grnch@gmx.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v3 1/4] fetch-pack: new --stdin option to read refs from stdin
Date: Mon, 2 Apr 2012 16:42:21 -0400 [thread overview]
Message-ID: <20120402204220.GC26503@sigill.intra.peff.net> (raw)
In-Reply-To: <4F79C22C.9080702@gmx.net>
On Mon, Apr 02, 2012 at 05:13:48PM +0200, Ivan Todoroski wrote:
> + else {
> + /* read from stdin one ref per line, until EOF */
> + struct strbuf line;
> + strbuf_init(&line, 0);
A minor style nit, but we usually spell this:
struct strbuf line = STRBUF_INIT;
Other than that, this version looks good to me. Thanks.
-Peff
next prev parent reply other threads:[~2012-04-02 20:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 15:11 [PATCH v3 0/4] Clone fails on a repo with too many heads/tags Ivan Todoroski
2012-04-02 15:13 ` [PATCH v3 1/4] fetch-pack: new --stdin option to read refs from stdin Ivan Todoroski
2012-04-02 20:42 ` Jeff King [this message]
2012-04-02 15:14 ` [PATCH v3 2/4] remote-curl: send the refs to fetch-pack on stdin Ivan Todoroski
2012-04-02 18:50 ` Junio C Hamano
2012-04-02 15:16 ` [PATCH v3 3/4] fetch-pack: test cases for the new --stdin option Ivan Todoroski
2012-04-02 19:34 ` Junio C Hamano
2012-04-03 0:23 ` Ivan Todoroski
2012-04-02 15:17 ` [PATCH v3 4/4] remote-curl: main test case for the OS command line overflow Ivan Todoroski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120402204220.GC26503@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=grnch@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).