From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] Fix a "Using plain integer as NULL pointer" sparse warning
Date: Tue, 3 Apr 2012 16:27:06 -0400 [thread overview]
Message-ID: <20120403202706.GA24815@sigill.intra.peff.net> (raw)
In-Reply-To: <4F7B331E.5080604@ramsay1.demon.co.uk>
On Tue, Apr 03, 2012 at 06:27:58PM +0100, Ramsay Jones wrote:
> If you need to re-roll your run-command patch [commit b0984f82,
> "run-command: treat inaccessible directories as ENOENT", 30-03-2012],
> could you please squash this patch into it. Thanks!
I don't think it needs re-rolled, but it hasn't hit next yet. Junio, can
you squash this in?
> diff --git a/run-command.c b/run-command.c
> index 47afb78..ae72b9b 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -86,7 +86,7 @@ static char *locate_in_PATH(const char *file)
> struct strbuf buf = STRBUF_INIT;
>
> if (!p || !*p)
> - return 0;
> + return NULL;
I missed this when converting the code from "is there anything in path"
to "here is what there is in path".
-Peff
prev parent reply other threads:[~2012-04-03 20:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 17:27 [PATCH] Fix a "Using plain integer as NULL pointer" sparse warning Ramsay Jones
2012-04-03 20:27 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403202706.GA24815@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).