* [PATCH] Fix a "Using plain integer as NULL pointer" sparse warning
@ 2012-04-03 17:27 Ramsay Jones
2012-04-03 20:27 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2012-04-03 17:27 UTC (permalink / raw)
To: Jeff King; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Jeff,
If you need to re-roll your run-command patch [commit b0984f82,
"run-command: treat inaccessible directories as ENOENT", 30-03-2012],
could you please squash this patch into it. Thanks!
ATB,
Ramsay Jones
run-command.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/run-command.c b/run-command.c
index 47afb78..ae72b9b 100644
--- a/run-command.c
+++ b/run-command.c
@@ -86,7 +86,7 @@ static char *locate_in_PATH(const char *file)
struct strbuf buf = STRBUF_INIT;
if (!p || !*p)
- return 0;
+ return NULL;
while (1) {
const char *end = strchrnul(p, ':');
--
1.7.9
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Fix a "Using plain integer as NULL pointer" sparse warning
2012-04-03 17:27 [PATCH] Fix a "Using plain integer as NULL pointer" sparse warning Ramsay Jones
@ 2012-04-03 20:27 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2012-04-03 20:27 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
On Tue, Apr 03, 2012 at 06:27:58PM +0100, Ramsay Jones wrote:
> If you need to re-roll your run-command patch [commit b0984f82,
> "run-command: treat inaccessible directories as ENOENT", 30-03-2012],
> could you please squash this patch into it. Thanks!
I don't think it needs re-rolled, but it hasn't hit next yet. Junio, can
you squash this in?
> diff --git a/run-command.c b/run-command.c
> index 47afb78..ae72b9b 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -86,7 +86,7 @@ static char *locate_in_PATH(const char *file)
> struct strbuf buf = STRBUF_INIT;
>
> if (!p || !*p)
> - return 0;
> + return NULL;
I missed this when converting the code from "is there anything in path"
to "here is what there is in path".
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-03 20:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-03 17:27 [PATCH] Fix a "Using plain integer as NULL pointer" sparse warning Ramsay Jones
2012-04-03 20:27 ` Jeff King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).