git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Kerrick Staley <mail@kerrickstaley.com>,
	gitster@pobox.com, git@vger.kernel.org,
	bash-completion-devel@lists.alioth.debian.org
Subject: Re: bash-completion now loads completions dynamically, so __git_ps1 is not defined when you open a shell
Date: Sat, 7 Apr 2012 08:47:49 -0500	[thread overview]
Message-ID: <20120407134749.GA2377@burratino> (raw)
In-Reply-To: <CAMP44s0rYpVhPpaf=C_aPoLUxy=EsiSxYNf04+B0_-MxzCftFw@mail.gmail.com>

Felipe Contreras wrote:
> On Thu, Mar 29, 2012 at 3:00 AM, Kerrick Staley <mail@kerrickstaley.com> wrote:

>> 1) define __git_ps1 (and friends) in a different script, which will
>> get installed in /etc/profile.d (this is the "proper way")
>
> I prefer this because it's useful for zsh as well

Sounds good to me.  In fact, I imagine you'll find no one it does not
sound good to.  Please feel free to make it so.

      reply	other threads:[~2012-04-07 13:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28 20:27 bash-completion now loads completions dynamically, so __git_ps1 is not defined when you open a shell Kerrick Staley
2012-03-28 22:17 ` Junio C Hamano
2012-03-29  5:57   ` Jeff King
2012-03-28 23:06 ` Jonathan Nieder
2012-03-29  0:00   ` Kerrick Staley
2012-03-29  5:49     ` Jeff King
2012-04-07 13:01     ` Felipe Contreras
2012-04-07 13:47       ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120407134749.GA2377@burratino \
    --to=jrnieder@gmail.com \
    --cc=bash-completion-devel@lists.alioth.debian.org \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mail@kerrickstaley.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).