From: Jonathan Nieder <jrnieder@gmail.com>
To: David Barr <davidbarr@google.com>
Cc: Git List <git@vger.kernel.org>,
Thomas Rast <trast@student.ethz.ch>,
Dmitry Ivankov <divanorama@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: [PATCH 4/4] fast-import: use DIV_ROUND_UP
Date: Wed, 11 Apr 2012 07:15:31 -0500 [thread overview]
Message-ID: <20120411121531.GF19568@burratino> (raw)
In-Reply-To: <20120411121259.GB19568@burratino>
Date: Mon, 30 May 2011 22:45:43 -0500
fast-import keeps tree structures for reuse in pools arranged by size:
one for trees with 0 entries, one for 8-entry trees, one for 16-entry
trees, and so on up to 784-entry trees, plus another pool for larger
trees. Use the DIV_ROUND_UP macro to determine which pool a
given-sized tree belongs in to avoid some confusing bit-twiddling.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Thanks for reading.
fast-import.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fast-import.c b/fast-import.c
index ebb27006..fc1b549d 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -785,7 +785,7 @@ static struct branch *new_branch(const char *name)
static unsigned int hc_entries(unsigned int cnt)
{
- cnt = cnt & 7 ? (cnt / 8) + 1 : cnt / 8;
+ cnt = DIV_ROUND_UP(cnt, 8);
return cnt < avail_tree_table_sz ? cnt : avail_tree_table_sz - 1;
}
@@ -805,7 +805,7 @@ static struct tree_content *new_tree_content(unsigned int cnt)
else
avail_tree_table[hc] = f->next_avail;
} else {
- cnt = cnt & 7 ? ((cnt / 8) + 1) * 8 : cnt;
+ cnt = DIV_ROUND_UP(cnt, 8) * 8;
f = pool_alloc(sizeof(*t) + sizeof(t->entries[0]) * cnt);
f->entry_capacity = cnt;
}
--
1.7.10
prev parent reply other threads:[~2012-04-11 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 11:59 fast-import: use struct hash_table David Barr
2011-03-31 11:59 ` [PATCH 1/2] fast-import: use struct hash_table for atom strings David Barr
2011-04-02 2:42 ` Jonathan Nieder
2011-04-02 3:33 ` Jonathan Nieder
2011-03-31 11:59 ` [PATCH 2/2] fast-import: use struct hash_table for objects David Barr
2011-04-02 2:46 ` Jonathan Nieder
2011-04-02 2:48 ` fast-import: use struct hash_table Jonathan Nieder
2012-04-11 12:11 ` [PATCH/RFC v2 0/4] " Jonathan Nieder
2012-04-11 12:12 ` [PATCH/RFC v2 0/4 resend] " Jonathan Nieder
2012-04-11 12:13 ` [PATCH 1/4] fast-import: allow object_table to grow dynamically Jonathan Nieder
2012-04-11 12:14 ` [PATCH 2/4] fast-import: allow atom_table " Jonathan Nieder
2012-04-11 12:15 ` [PATCH 3/4] fast-import: allow branch_table " Jonathan Nieder
2012-04-11 12:15 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411121531.GF19568@burratino \
--to=jrnieder@gmail.com \
--cc=davidbarr@google.com \
--cc=divanorama@gmail.com \
--cc=git@vger.kernel.org \
--cc=srabbelier@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).