From: Jeff King <peff@peff.net>
To: mhagger@alum.mit.edu
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>,
Heiko Voigt <hvoigt@hvoigt.net>,
Johan Herland <johan@herland.net>
Subject: Re: [PATCH 00/15] Hierarchical reference cache (once again)
Date: Thu, 12 Apr 2012 02:44:59 -0400 [thread overview]
Message-ID: <20120412064459.GD27369@sigill.intra.peff.net> (raw)
In-Reply-To: <1334035827-20331-1-git-send-email-mhagger@alum.mit.edu>
On Tue, Apr 10, 2012 at 07:30:12AM +0200, mhagger@alum.mit.edu wrote:
> Michael Haggerty (15):
> refs.c: reorder definitions more logically
> refs: manage current_ref within do_one_ref()
> do_for_each_ref_in_array(): new function
> do_for_each_ref_in_arrays(): new function
> repack_without_ref(): reimplement using do_for_each_ref_in_array()
> names_conflict(): new function, extracted from is_refname_available()
> names_conflict(): simplify implementation
> is_refname_available(): reimplement using do_for_each_ref_in_array()
> free_ref_entry(): new function
> check_refname_component(): return 0 for zero-length components
> struct ref_entry: nest the value part in a union
> refs.c: rename ref_array -> ref_dir
> sort_ref_dir(): simplify logic
> refs: store references hierarchically
> do_for_each_ref(): only iterate over the subtree that was requested
I read through the whole series and didn't find anything noticeably
wrong. Overall, it was quite readable for such a large series. Thanks
for breaking it up as you did.
-Peff
next prev parent reply other threads:[~2012-04-12 6:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 5:30 [PATCH 00/15] Hierarchical reference cache (once again) mhagger
2012-04-10 5:30 ` [PATCH 01/15] refs.c: reorder definitions more logically mhagger
2012-04-10 5:30 ` [PATCH 02/15] refs: manage current_ref within do_one_ref() mhagger
2012-04-10 5:30 ` [PATCH 03/15] do_for_each_ref_in_array(): new function mhagger
2012-04-10 5:30 ` [PATCH 04/15] do_for_each_ref_in_arrays(): " mhagger
2012-04-10 5:30 ` [PATCH 05/15] repack_without_ref(): reimplement using do_for_each_ref_in_array() mhagger
2012-04-10 5:30 ` [PATCH 06/15] names_conflict(): new function, extracted from is_refname_available() mhagger
2012-04-10 5:30 ` [PATCH 07/15] names_conflict(): simplify implementation mhagger
2012-04-10 5:30 ` [PATCH 08/15] is_refname_available(): reimplement using do_for_each_ref_in_array() mhagger
2012-04-10 5:30 ` [PATCH 09/15] free_ref_entry(): new function mhagger
2012-04-10 5:30 ` [PATCH 10/15] check_refname_component(): return 0 for zero-length components mhagger
2012-04-10 5:30 ` [PATCH 11/15] struct ref_entry: nest the value part in a union mhagger
2012-04-10 5:30 ` [PATCH 12/15] refs.c: rename ref_array -> ref_dir mhagger
2012-04-10 5:30 ` [PATCH 13/15] sort_ref_dir(): simplify logic mhagger
2012-04-10 5:30 ` [PATCH 14/15] refs: store references hierarchically mhagger
2012-04-10 5:30 ` [PATCH 15/15] do_for_each_ref(): only iterate over the subtree that was requested mhagger
2012-04-12 6:44 ` Jeff King [this message]
2012-04-12 15:36 ` [PATCH 00/15] Hierarchical reference cache (once again) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412064459.GD27369@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=jnareb@gmail.com \
--cc=johan@herland.net \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).