git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christopher Tiwald <christiwald@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brian Gernhardt <brian@silverinsanity.com>,
	Git List <git@vger.kernel.org>
Subject: [PATCH] Fix httpd tests that broke when non-ff push advice changed
Date: Thu, 12 Apr 2012 13:56:28 -0400	[thread overview]
Message-ID: <20120412175628.GH367@gmail.com> (raw)
In-Reply-To: <7v8vi1gdzk.fsf@alter.siamese.dyndns.org>

On Thu, Apr 12, 2012 at 08:35:11AM -0700, Junio C Hamano wrote:
> Please do so.  I assume that the test vectors were expecting specific
> error/advice messages that need to be updated?

Looks to be the case. The below fixes the tests on my machine. It might
be worth adding tests to check the specific advice messages, but that's a
different topic and regardless wouldn't belong in the http-push series.

---- >8 ----
Signed-off-by: Christopher Tiwald <christiwald@gmail.com>
---
 t/lib-httpd.sh       |    2 +-
 t/t5541-http-push.sh |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh
index f7dc078..094d490 100644
--- a/t/lib-httpd.sh
+++ b/t/lib-httpd.sh
@@ -160,6 +160,6 @@ test_http_push_nonff() {
 	'
 
 	test_expect_success 'non-fast-forward push shows help message' '
-		test_i18ngrep "To prevent you from losing history, non-fast-forward updates were rejected" output
+		test_i18ngrep "Updates were rejected because" output
 	'
 }
diff --git a/t/t5541-http-push.sh b/t/t5541-http-push.sh
index cc6f081..57c3e48 100755
--- a/t/t5541-http-push.sh
+++ b/t/t5541-http-push.sh
@@ -167,7 +167,7 @@ test_expect_success 'push fails for non-fast-forward refs unmatched by remote he
 '
 
 test_expect_success 'push fails for non-fast-forward refs unmatched by remote helper: our output' '
-	test_i18ngrep "To prevent you from losing history, non-fast-forward updates were rejected" \
+	test_i18ngrep "Updates were rejected because" \
 		output
 '
 
-- 
1.7.10.167.gf245c

--
Christopher Tiwald

  reply	other threads:[~2012-04-12 17:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12  5:49 non-fast-forward advice breaks tests on OS X Brian Gernhardt
2012-04-12 13:37 ` Christopher Tiwald
2012-04-12 14:00   ` Christopher Tiwald
2012-04-12 15:35     ` Junio C Hamano
2012-04-12 17:56       ` Christopher Tiwald [this message]
2012-04-12 21:51         ` [PATCH] Fix httpd tests that broke when non-ff push advice changed Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120412175628.GH367@gmail.com \
    --to=christiwald@gmail.com \
    --cc=brian@silverinsanity.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).