From: Jeff King <peff@peff.net>
To: Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
Cc: git@vger.kernel.org, sam@vilain.net
Subject: Re: [PATCH v5 2/5] http: handle proxy proactive authentication
Date: Fri, 13 Apr 2012 16:56:50 -0400 [thread overview]
Message-ID: <20120413205649.GC7919@sigill.intra.peff.net> (raw)
In-Reply-To: <4F5F53CA.7090003@seap.minhap.es>
On Tue, Mar 13, 2012 at 03:03:54PM +0100, Nelson Benitez Leon wrote:
> Also take care that CURLOPT_PROXY don't include username or
> password, as we now set them in the new set_proxy_auth() function
> where we use their specific cURL options.
Did you test that this is necessary? We don't do it for the regular URL
case, and it makes the code much simpler if we can avoid munging what we
hand to curl.
> +static void set_proxy_auth(CURL *result)
> +{
> + if (proxy_auth.username && proxy_auth.password) {
> +#if LIBCURL_VERSION_NUM >= 0x071901
> + curl_easy_setopt(result, CURLOPT_PROXYUSERNAME, proxy_auth.username);
> + curl_easy_setopt(result, CURLOPT_PROXYPASSWORD, proxy_auth.password);
> +#else
Is that version check right? You are giving a hexadecimal number, so
7.19.1 would be 071301.
-Peff
next prev parent reply other threads:[~2012-04-13 20:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 14:03 [PATCH v5 2/5] http: handle proxy proactive authentication Nelson Benitez Leon
2012-04-09 21:39 ` Junio C Hamano
2012-04-10 0:59 ` Junio C Hamano
2012-04-12 15:54 ` Junio C Hamano
2012-04-12 20:58 ` Jeff King
2012-04-12 21:25 ` Junio C Hamano
2012-04-12 22:05 ` Jeff King
2012-04-12 22:18 ` Junio C Hamano
2012-04-12 22:42 ` Jeff King
2012-04-13 19:35 ` Junio C Hamano
2012-04-13 20:23 ` Jeff King
2012-04-13 20:56 ` Jeff King [this message]
2012-04-19 17:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413205649.GC7919@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nelsonjesus.benitez@seap.minhap.es \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).