From: Jonathan Nieder <jrnieder@gmail.com>
To: Andrew Sayers <andrew-git@pileofstuff.org>
Cc: Git Mailing List <git@vger.kernel.org>,
David Barr <davidbarr@google.com>,
Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [BUG] svn-fe: incorrect handling of files with newlines in them
Date: Fri, 13 Apr 2012 17:22:01 -0500 [thread overview]
Message-ID: <20120413222201.GA20197@burratino> (raw)
In-Reply-To: <4F88A502.9080207@pileofstuff.org>
(+cc: Ram)
Hey,
Andrew Sayers wrote:
> Note that I've used the intentionally provocative filename
> $'readme.txt\nNode-kind: dir', but svn-fe doesn't fall for the trick.
> The dump format doesn't escape the filename at all, so it would probably
> fall for something cleverer like a 'copyfrom' line. To be honest I'm
> not sure how you'd even detect such a filename.
Yep, sounds like a dump-load-format design bug.
> If the consensus is that this bug isn't fixable, I'd recommend putting a
> note to that effect in "contrib/svn-fe/svn-fe.txt".
Makes sense. Please make it so.
Thanks much,
Jonathan
prev parent reply other threads:[~2012-04-13 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 22:13 [BUG] svn-fe: incorrect handling of files with newlines in them Andrew Sayers
2012-04-13 22:22 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413222201.GA20197@burratino \
--to=jrnieder@gmail.com \
--cc=andrew-git@pileofstuff.org \
--cc=artagnon@gmail.com \
--cc=davidbarr@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).