From: Jonathan Nieder <jrnieder@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>,
"Junio C Hamano" <gitster@pobox.com>,
"Thomas Rast" <trast@student.ethz.ch>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH v3 0/5] completion: trivial cleanups and fixes
Date: Sun, 15 Apr 2012 08:20:02 -0500 [thread overview]
Message-ID: <20120415132002.GB2544@burratino> (raw)
In-Reply-To: <1334439784-6460-1-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras wrote:
> Just a few simpliciations, improvements, and add some missing options.
I generally like this. Quick comments:
> Felipe Contreras (3):
> completion: simplify __gitcomp_1
Thomas and Gábor seem to have this one covered, with some improvements
to it under discussion.
> completion: trivial simplification
Improves consistency. The changelog line isn't precise enough to
remind me which change is being mentioned when reading it in the
shortlog, so I guess I'd prefer something like
completion: simplify by using $prev variable
> completion: add missing general options
Likewise, a subject line like the following would work better for
me.
completion: --info-path and --no-replace-objects options for git
Hope that helps,
Jonathan
next prev parent reply other threads:[~2012-04-15 13:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 21:42 [PATCH v3 0/5] completion: trivial cleanups and fixes Felipe Contreras
2012-04-14 21:43 ` [PATCH v3 1/5] completion: simplify __gitcomp_1 Felipe Contreras
2012-04-14 22:36 ` Thomas Rast
2012-04-14 22:54 ` Felipe Contreras
2012-04-15 4:45 ` Felipe Contreras
2012-04-15 8:29 ` Andreas Schwab
2012-04-15 9:33 ` SZEDER Gábor
2012-04-15 9:49 ` Andreas Schwab
2012-04-15 10:09 ` SZEDER Gábor
2012-04-14 21:43 ` [PATCH v3 2/5] completion: trivial simplification Felipe Contreras
2012-04-14 21:43 ` [PATCH v3 3/5] completion: add missing general options Felipe Contreras
2012-04-14 21:43 ` [PATCH v3 4/5] completion: avoid trailing space for --exec-path Felipe Contreras
2012-04-14 21:43 ` [PATCH v3 5/5] completion: fix completion after 'git --option <TAB>' Felipe Contreras
2012-04-15 13:20 ` Jonathan Nieder [this message]
2012-04-15 19:42 ` [PATCH v3 0/5] completion: trivial cleanups and fixes Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120415132002.GB2544@burratino \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=szeder@ira.uka.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).