From: Jonathan Nieder <jrnieder@gmail.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>, Jeff King <peff@peff.net>
Subject: Re: [PATCH] tests: add tests for the bash prompt functions in the completion script
Date: Mon, 16 Apr 2012 11:01:24 -0500 [thread overview]
Message-ID: <20120416160124.GL5813@burratino> (raw)
In-Reply-To: <20120416094938.GE2900@goldbirke>
SZEDER Gábor wrote:
> I thought about that briefly but decided against it to avoid
> duplicating the bash-specific checks at the beginning, but I don't
> care that much either way.
Maybe a t/lib-completion.sh would take care of that. FWIW a clean
split in the test script so it doesn't grow into something like the
current fast-import tests sounds like a good idea to me. :)
next prev parent reply other threads:[~2012-04-16 16:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 20:31 [PATCH] tests: add tests for the bash prompt functions in the completion script SZEDER Gábor
2012-04-15 20:56 ` Felipe Contreras
2012-04-16 9:49 ` SZEDER Gábor
2012-04-16 10:04 ` Felipe Contreras
2012-04-16 10:20 ` SZEDER Gábor
2012-04-16 16:01 ` Jonathan Nieder [this message]
2012-04-16 22:09 ` [PATCH v2 1/2] tests: move code to run completion tests under bash into a helper library SZEDER Gábor
2012-04-16 22:09 ` [PATCH v2 2/2] tests: add tests for the bash prompt functions in the completion script SZEDER Gábor
2012-04-16 23:50 ` Jonathan Nieder
2012-04-17 0:33 ` SZEDER Gábor
2012-04-16 23:49 ` [PATCH v2 1/2] tests: move code to run completion tests under bash into a helper library Jonathan Nieder
2012-04-17 0:42 ` SZEDER Gábor
2012-04-17 7:20 ` Johannes Sixt
2012-04-17 7:37 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416160124.GL5813@burratino \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=szeder@ira.uka.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).