From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>,
"Thomas Rast" <trast@student.ethz.ch>
Subject: Re: [PATCH v2] completion: add new git_complete helper
Date: Mon, 16 Apr 2012 11:07:29 -0500 [thread overview]
Message-ID: <20120416160729.GM5813@burratino> (raw)
In-Reply-To: <7vaa2by8nj.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> I am OK with introducing git_ps1 while keeping __git_ps1 as an equivalent
> and declare that git_$anything will be the surface interface for end users
> to *use* the machinery we provide, though.
The problem is that completion scripts are often included implicitly
in .profile through the bash completion machinery. Users do not have
to explicitly ask for them, so there is no reason for users to expect
that the function name "more_cowbell" is dangerous to use in .profile
because some day the completion script for the "more" command will
start using it.
Because of these considerations, the convention is that every
identifier provided by a completion script, including public ones,
starts with an underscore.
next prev parent reply other threads:[~2012-04-16 16:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 21:20 [PATCH v2] completion: add new git_complete helper Felipe Contreras
2012-04-15 21:37 ` Jonathan Nieder
2012-04-16 10:49 ` Felipe Contreras
2012-04-16 15:54 ` Junio C Hamano
2012-04-16 16:07 ` Jonathan Nieder [this message]
2012-04-16 16:32 ` Junio C Hamano
2012-04-16 20:04 ` Felipe Contreras
2012-04-16 20:09 ` Jonathan Nieder
2012-04-16 20:30 ` Felipe Contreras
2012-04-16 20:33 ` Jonathan Nieder
2012-04-16 20:42 ` Felipe Contreras
2012-04-16 20:46 ` Jonathan Nieder
2012-04-16 20:51 ` Felipe Contreras
2012-04-16 20:59 ` Jonathan Nieder
2012-04-21 7:20 ` Ville Skyttä
2012-04-21 15:41 ` [Bash-completion-devel] " Felipe Contreras
2012-04-21 17:39 ` Ville Skyttä
2012-04-22 12:58 ` Felipe Contreras
2012-04-16 20:51 ` Junio C Hamano
2012-04-16 21:09 ` Felipe Contreras
2012-04-16 22:44 ` Jonathan Nieder
2012-04-16 23:04 ` Felipe Contreras
2012-04-16 23:05 ` Jonathan Nieder
2012-04-16 23:16 ` Jonathan Nieder
2012-04-17 7:10 ` Felipe Contreras
2012-04-17 7:36 ` Jonathan Nieder
2012-04-17 7:56 ` Felipe Contreras
2012-04-17 8:06 ` Jonathan Nieder
2012-04-17 8:22 ` Jonathan Nieder
2012-04-16 16:00 ` Jonathan Nieder
2012-04-16 22:15 ` SZEDER Gábor
2012-04-16 22:33 ` Felipe Contreras
2012-04-17 15:50 ` Junio C Hamano
2012-04-17 16:13 ` Felipe Contreras
2012-04-17 18:15 ` Junio C Hamano
2012-04-17 20:53 ` Felipe Contreras
2012-04-17 21:08 ` Jonathan Nieder
2012-04-17 22:14 ` SZEDER Gábor
2012-04-17 22:19 ` Felipe Contreras
2012-04-17 17:50 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416160729.GM5813@burratino \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder@ira.uka.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).