git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>,
	"Thomas Rast" <trast@student.ethz.ch>
Subject: Re: [PATCH v2] completion: add new git_complete helper
Date: Mon, 16 Apr 2012 17:44:11 -0500	[thread overview]
Message-ID: <20120416224411.GU12613@burratino> (raw)
In-Reply-To: <CAMP44s1TkE=rd8AxbBnR4a8FwY+H9MHxYOhcks9fsnuK1iL_oA@mail.gmail.com>

Felipe Contreras wrote:

> Even more, I just added a foobar() function in my profile, and I also
> added a foobar() function in /etc/bash_completion.d/git. I don't see
> my function replaced in any way, even after typing and completing
> 'git' commands. I don't know how that's possible, but that's why I
> don't like to take these types of claims as face value.

What version of the bash_completion library do you use?  Lazy-loading
was introduced in version 1.90.

If you put

	foobar() {
		echo hi
	}
	. /etc/bash_completion

then is your private foobar unclobbered?

To answer your demand before for a function in the public interface of
a completion script, not library, which respects or does not respect
the bash-completion convention: see the public _rpm_installed_packages
helper from the rpm completion script[1].

If you don't like the convention or think that I have misunderstood
it, I can understand that and would recommend that you suggest a
different one and get it adopted and documented by the bash_completion
project.

Jonathan

[1] http://lists.alioth.debian.org/pipermail/bash-completion-devel/2012-March/004359.html

  reply	other threads:[~2012-04-16 22:44 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-15 21:20 [PATCH v2] completion: add new git_complete helper Felipe Contreras
2012-04-15 21:37 ` Jonathan Nieder
2012-04-16 10:49   ` Felipe Contreras
2012-04-16 15:54     ` Junio C Hamano
2012-04-16 16:07       ` Jonathan Nieder
2012-04-16 16:32         ` Junio C Hamano
2012-04-16 20:04         ` Felipe Contreras
2012-04-16 20:09           ` Jonathan Nieder
2012-04-16 20:30             ` Felipe Contreras
2012-04-16 20:33               ` Jonathan Nieder
2012-04-16 20:42                 ` Felipe Contreras
2012-04-16 20:46                   ` Jonathan Nieder
2012-04-16 20:51                     ` Felipe Contreras
2012-04-16 20:59                       ` Jonathan Nieder
2012-04-21  7:20                         ` Ville Skyttä
2012-04-21 15:41                           ` [Bash-completion-devel] " Felipe Contreras
2012-04-21 17:39                             ` Ville Skyttä
2012-04-22 12:58                               ` Felipe Contreras
2012-04-16 20:51                 ` Junio C Hamano
2012-04-16 21:09                   ` Felipe Contreras
2012-04-16 22:44                     ` Jonathan Nieder [this message]
2012-04-16 23:04                       ` Felipe Contreras
2012-04-16 23:05                         ` Jonathan Nieder
2012-04-16 23:16                         ` Jonathan Nieder
2012-04-17  7:10                           ` Felipe Contreras
2012-04-17  7:36                             ` Jonathan Nieder
2012-04-17  7:56                               ` Felipe Contreras
2012-04-17  8:06                                 ` Jonathan Nieder
2012-04-17  8:22                                 ` Jonathan Nieder
2012-04-16 16:00     ` Jonathan Nieder
2012-04-16 22:15   ` SZEDER Gábor
2012-04-16 22:33     ` Felipe Contreras
2012-04-17 15:50       ` Junio C Hamano
2012-04-17 16:13         ` Felipe Contreras
2012-04-17 18:15           ` Junio C Hamano
2012-04-17 20:53             ` Felipe Contreras
2012-04-17 21:08               ` Jonathan Nieder
2012-04-17 22:14               ` SZEDER Gábor
2012-04-17 22:19                 ` Felipe Contreras
2012-04-17 17:50         ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120416224411.GU12613@burratino \
    --to=jrnieder@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=szeder@ira.uka.de \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).