From: Jonathan Nieder <jrnieder@gmail.com>
To: Marc Branchaud <marcnarc@xiplink.com>
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] fetch: Use the remote's ref name to decide how to describe new refs.
Date: Tue, 17 Apr 2012 10:18:27 -0500 [thread overview]
Message-ID: <20120417151826.GA21534@burratino> (raw)
In-Reply-To: <4F8D7CD5.3080508@xiplink.com>
Hi again,
Marc Branchaud wrote:
> Jonathan, I figured regexps aren't an issue with plain "grep" (unlike "egrep"
> or "grep -e"). I take it this is a portability concern -- are there systems
> that actually replace plain "grep" like a "egrep"?
No, "grep" always means to globally match against a regexp and print.
There is an "fgrep" command to search for a fixed string, but why not
take advantage of regexps while they're available and use one grep
instead of two?
> Also, in my test's pipes I believe only the second "grep" needs to be
> "test_i18ngrep", right? (Only strings like "[new branch]" are
> internationalized.)
I'm not sure what the point would be. The exit status from the
upstream of a pipe doesn't affect the outcome of the test, so no one
would be able to tell the difference.
[...]
> Thanks guys!
Thank you.
Sincerely,
Jonathan
next prev parent reply other threads:[~2012-04-17 15:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 17:08 [PATCHv2] fetch: Only call a new ref a "branch" if it's under refs/heads/ marcnarc
2012-04-13 20:07 ` Jonathan Nieder
2012-04-16 14:26 ` Marc Branchaud
2012-04-13 21:13 ` Jeff King
2012-04-13 21:53 ` Jonathan Nieder
2012-04-13 22:39 ` Junio C Hamano
2012-04-16 14:58 ` Marc Branchaud
2012-04-16 15:00 ` Jeff King
2012-04-16 15:52 ` [PATCHv3] fetch: Use the remote's ref name to decide how to describe new refs marcnarc
2012-04-16 16:10 ` Jonathan Nieder
2012-04-16 17:59 ` Junio C Hamano
2012-04-16 20:21 ` Marc Branchaud
2012-04-16 22:08 ` [PATCHv4 0/3] fetch: Only call a new ref a "branch" if it's under refs/heads/ marcnarc
2012-04-16 22:08 ` [PATCH 1/3] submodules: recursive fetch also checks new tags for submodule commits marcnarc
2012-04-16 22:08 ` [PATCH 2/3] fetch: Pass both the full remote ref and its short name to update_local_ref() marcnarc
2012-04-16 22:08 ` [PATCH 3/3] fetch: Use the remote's ref name to decide how to describe new refs marcnarc
2012-04-16 22:34 ` Jonathan Nieder
2012-04-17 7:53 ` Zbigniew Jędrzejewski-Szmek
2012-04-17 7:57 ` Jonathan Nieder
2012-04-17 8:39 ` Zbigniew Jędrzejewski-Szmek
2012-04-17 14:23 ` Marc Branchaud
2012-04-17 15:18 ` Jonathan Nieder [this message]
2012-04-17 15:26 ` [PATCHv4 0/3] fetch: Only call a new ref a "branch" if it's under refs/heads/ Junio C Hamano
2012-04-17 15:28 ` Junio C Hamano
2012-04-17 19:30 ` Marc Branchaud
2012-04-17 22:29 ` Jeff King
2012-04-16 16:08 ` [PATCHv2] " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417151826.GA21534@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=marcnarc@xiplink.com \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).