From mboxrd@z Thu Jan 1 00:00:00 1970 From: SZEDER =?iso-8859-1?Q?G=E1bor?= Subject: Re: [PATCH v2] completion: add new git_complete helper Date: Tue, 17 Apr 2012 19:50:17 +0200 Message-ID: <20120417175017.GC10081@goldbirke> References: <1334524814-13581-1-git-send-email-felipe.contreras@gmail.com> <20120415213718.GB5813@burratino> <20120416221531.GA2299@goldbirke> <7vty0inys6.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Felipe Contreras , Jonathan Nieder , , Thomas Rast To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Apr 17 19:50:35 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SKCXs-0005OQ-U8 for gcvg-git-2@plane.gmane.org; Tue, 17 Apr 2012 19:50:29 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015Ab2DQRuY convert rfc822-to-quoted-printable (ORCPT ); Tue, 17 Apr 2012 13:50:24 -0400 Received: from ex-e-2.perimeter.fzi.de ([141.21.8.251]:37997 "EHLO ex-e-2.perimeter.fzi.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526Ab2DQRuX (ORCPT ); Tue, 17 Apr 2012 13:50:23 -0400 Received: from ex-ca-ht-1.fzi.de (141.21.32.98) by ex-e-2.perimeter.fzi.de (141.21.8.251) with Microsoft SMTP Server (TLS) id 14.1.355.2; Tue, 17 Apr 2012 19:50:17 +0200 Received: from localhost6.localdomain6 (141.21.50.31) by ex-ca-ht-1.fzi.de (141.21.32.98) with Microsoft SMTP Server (TLS) id 14.1.355.2; Tue, 17 Apr 2012 19:50:17 +0200 Content-Disposition: inline In-Reply-To: <7vty0inys6.fsf@alter.siamese.dyndns.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Tue, Apr 17, 2012 at 08:50:01AM -0700, Junio C Hamano wrote: > Felipe Contreras writes: >=20 > > 2012/4/17 SZEDER G=E1bor : > >> On Sun, Apr 15, 2012 at 04:37:18PM -0500, Jonathan Nieder wrote: > >>> Felipe Contreras wrote: > > > >>> A name like __git_complete should work, presumably. > >> > >> And foo_wrap() should also fit into those namespaces. > > > > Yeah, I don't have a problem with that, just forgot about it. > > > > But git_complete I think is different. >=20 > Is git_complete something the user types interactively, or is it mean= t to > be used in their .bashrc to help them complete arguments to their cus= tom > scripts that take arguments similar to Git Porcelains? Primarily for .bashrc, however, not for their custom scripts but to be able to use completion for their one-word git aliases, e.g. after an alias gf=3D'git fetch' they want to do gf o and get 'origin' completed. Here's a relevant thread: http://thread.gmane.org/gmane.comp.version-control.git/185184/ Best, G=E1bor