git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gc: fix off-by-one in append_option
Date: Wed, 18 Apr 2012 14:07:40 -0700	[thread overview]
Message-ID: <20120418210740.GA21214@sigill.intra.peff.net> (raw)
In-Reply-To: <20120418202116.GA12964@sigill.intra.peff.net>

On Wed, Apr 18, 2012 at 01:21:16PM -0700, Jeff King wrote:

> > I am perfectly OK with even without initializers, like this:
> > 
> > 	struct argv_array repack = ARGV_ARRAY_INIT;
> > 	argv_array_push_strings(&repack, "repack", "-d", "-l", NULL);
> 
> I think that is sane, and certainly the simplest. I'll send a patch in a
> moment.

Here it is. This goes directly on top of 7e52f56 (the tip of
jk/repack-no-explode-objects-from-old-pack). The off-by-one fix I sent
earlier can be dropped, as that code is removed by the final patch
below.

  [1/3]: argv-array: refactor empty_argv initialization
  [2/3]: argv-array: add a new "pushl" method
  [3/3]: gc: use argv-array for sub-commands

-Peff

  reply	other threads:[~2012-04-18 21:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17 23:32 [PATCH] gc: fix off-by-one in append_option Jeff King
2012-04-18 19:18 ` Jeff King
2012-04-18 19:34   ` Junio C Hamano
2012-04-18 20:21     ` Jeff King
2012-04-18 21:07       ` Jeff King [this message]
2012-04-18 21:08         ` [PATCH 1/3] argv-array: refactor empty_argv initialization Jeff King
2012-04-18 21:10         ` [PATCH 2/3] argv-array: add a new "pushl" method Jeff King
2012-04-18 21:10         ` [PATCH 3/3] gc: use argv-array for sub-commands Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418210740.GA21214@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).