From: Jeff King <peff@peff.net>
To: Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Try an uppercase version of $prot_proxy env var
Date: Thu, 26 Apr 2012 09:08:54 -0400 [thread overview]
Message-ID: <20120426130854.GC27785@sigill.intra.peff.net> (raw)
In-Reply-To: <4F994AC3.2070708@seap.minhap.es>
On Thu, Apr 26, 2012 at 03:16:51PM +0200, Nelson Benitez Leon wrote:
> Try an uppercase version of $prot_proxy env var when thelowercase version
> is not found.
> [...]
> diff --git a/http.c b/http.c
> index 6a98195..bf9c20e 100644
> --- a/http.c
> +++ b/http.c
> @@ -329,6 +329,13 @@ static CURL *get_curl_handle(const char *url)
> strbuf_addf(&buf, "%s_proxy", cre_url.protocol);
> env_proxy_var = strbuf_detach(&buf, NULL);
> env_proxy = getenv(env_proxy_var);
> + if (!env_proxy) {
> + char *p;
> + for (p = env_proxy_var; *p; p++) {
> + *p = toupper(*p);
> + }
> + env_proxy = getenv(env_proxy_var);
> + }
Don't we explicitly not want to do this when the protocol is http? Curl
doesn't respect HTTP_PROXY.
-Peff
next prev parent reply other threads:[~2012-04-26 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 22:04 What's cooking in git.git (Apr 2012, #09; Mon, 23) Junio C Hamano
2012-04-24 9:14 ` Nelson Benitez Leon
2012-04-24 18:57 ` Junio C Hamano
2012-04-26 13:16 ` [PATCH] Try an uppercase version of $prot_proxy env var Nelson Benitez Leon
2012-04-26 13:08 ` Jeff King [this message]
2012-04-26 15:18 ` Junio C Hamano
2012-04-26 16:29 ` Nelson Benitez Leon
2012-04-27 8:12 ` Jeff King
2012-04-27 15:03 ` Junio C Hamano
2012-04-26 14:04 ` Junio C Hamano
2012-04-25 2:14 ` What's cooking (incremental) Junio C Hamano
2012-04-25 9:06 ` Thomas Rast
2012-04-25 15:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426130854.GC27785@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nelsonjesus.benitez@seap.minhap.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).