From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Michael Haggerty <mhagger@alum.mit.edu>, git@vger.kernel.org
Subject: Re: ref-format checking regression
Date: Sat, 28 Apr 2012 05:24:50 -0400 [thread overview]
Message-ID: <20120428092450.GA2850@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqr4v99pu5.fsf@junio.mtv.corp.google.com>
On Fri, Apr 27, 2012 at 08:06:26AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > I upgraded git on a machine recently, and it created problems for a repo
> > with a bogus character in a ref name. Older versions of git never
> > complained about it. Newer ones, containing your dce4bab ("add_ref():
> > verify that the refname is formatted correctly") do. That's fine; it's
> > bogus and git _should_ complain about it.
> >
> > However, recovering from the situation is unnecessarily hard, ...
> > ...
> > I seem to recall discussing this format-tightening and trying to be sure
> > that users were left with a way forward for fixing their repos. But I
> > can't find the discussion, and I don't recall any conclusion we came to.
>
> I haven't dug the archive but I do recall pointing many issues out
> around the theme "be liberal in what you accept and strict in what you
> produce" on this topic, and loosening one or two showstoppers during the
> review cycle, but obviously we did not catch all of them.
I should point out that this was due to GitHub recently upgrading the
version of git on our backend servers. And out of the bazillion repos we
host, I have so far seen only one actual bug report. So while it might
be nice to be more friendly, it may simply not be all that common an
issue (and in this case, we were able to resolve it manually). If it's
easy to fix, I think we should, but if the fix ends up being very
complex, it might not be worth the trouble.
-Peff
prev parent reply other threads:[~2012-04-28 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 11:50 ref-format checking regression Jeff King
2012-04-27 12:57 ` Ævar Arnfjörð Bjarmason
2012-04-27 15:06 ` Junio C Hamano
2012-04-27 15:25 ` Junio C Hamano
2012-04-28 9:24 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120428092450.GA2850@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).