Re: 1.7.10 doesn't show file pushstatus

[Jeff King <peff@peff.net>]

> I just updated to msysGit 1.7.10 and I noticed I don't see any details
> while pushing (like file upload speed and % completion). Was this
> intentionally removed? If so why?

No, it's a regression. I can reproduce it easily, and it bisects to
Clemens' 01fdc21 (push/fetch/clone --no-progress suppresses progress
output) which went into v1.7.9.2 (and v1.7.10).

The problematic hunk is:

diff --git a/builtin/send-pack.c b/builtin/send-pack.c
index 71f258e..9df341c 100644
--- a/builtin/send-pack.c
+++ b/builtin/send-pack.c
@@ -58,7 +58,7 @@ static int pack_objects(int fd, struct ref *refs, struct extra_have_objects *ext
                argv[i++] = "--thin";
        if (args->use_ofs_delta)
                argv[i++] = "--delta-base-offset";
-       if (args->quiet)
+       if (args->quiet || !args->progress)
                argv[i++] = "-q";
        if (args->progress)
                argv[i++] = "--progress";

which seems wrong to me. In send-pack, args->progress may be unset if we
didn't get a --progress flag on the command line. Shouldn't we be
falling back to isatty in that case (or leaving "-q" unset so that
pack-objects can do so)? Does it need to also be converted into a
tri-state of yes/no/unknown as the other places in that patch were?
Clemens?

-Peff

-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en