From: Clemens Buchacher <drizzd@aon.at>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, dfowler <davidfowl@gmail.com>,
git@vger.kernel.org, msysgit@googlegroups.com,
Paul Betts <paul@github.com>, David Ebbo <david.ebbo@gmail.com>
Subject: Re: [PATCH 3/3] t5541: test more combinations of --progress
Date: Tue, 1 May 2012 11:35:01 +0200 [thread overview]
Message-ID: <20120501093501.GB22633@ecki.lan> (raw)
In-Reply-To: <20120501084307.GC4998@sigill.intra.peff.net>
Can we add this on top or squashed in? I regret using tee when I
originally wrote the test.
--8<--
Subject: [PATCH] t5541: check return codes
By piping output to tee, the return code of the command is hidden.
Instead, redirect output to a file directly.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
t/t5541-http-push.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t5541-http-push.sh b/t/t5541-http-push.sh
index 986210a..c07973e 100755
--- a/t/t5541-http-push.sh
+++ b/t/t5541-http-push.sh
@@ -218,21 +218,21 @@ test_expect_success 'push --mirror to repo with alternates' '
test_expect_success TTY 'push shows progress when stderr is a tty' '
cd "$ROOT_PATH"/test_repo_clone &&
test_commit noisy &&
- test_terminal git push 2>&1 | tee output &&
+ test_terminal git push >output 2>&1 &&
grep "^Writing objects" output
'
test_expect_success TTY 'push --quiet silences status and progress' '
cd "$ROOT_PATH"/test_repo_clone &&
test_commit quiet &&
- test_terminal git push --quiet 2>&1 | tee output &&
+ test_terminal git push --quiet >output 2>&1 &&
test_cmp /dev/null output
'
test_expect_success TTY 'push --no-progress silences progress but not status' '
cd "$ROOT_PATH"/test_repo_clone &&
test_commit no-progress &&
- test_terminal git push --no-progress 2>&1 | tee output &&
+ test_terminal git push --no-progress >output 2>&1 &&
grep "^To http" output &&
! grep "^Writing objects"
'
@@ -240,7 +240,7 @@ test_expect_success TTY 'push --no-progress silences progress but not status' '
test_expect_success 'push --progress shows progress to non-tty' '
cd "$ROOT_PATH"/test_repo_clone &&
test_commit progress &&
- git push --progress 2>&1 | tee output &&
+ git push --progress >output 2>&1 &&
grep "^To http" output &&
grep "^Writing objects" output
'
--
1.7.10
next prev parent reply other threads:[~2012-05-01 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120501010609.GA14715@jupiter.local>
2012-05-01 6:58 ` 1.7.10 doesn't show file pushstatus Jeff King
2012-05-01 7:33 ` Jeff King
2012-05-01 8:40 ` Jeff King
2012-05-01 8:41 ` [PATCH 1/3] send-pack: show progress when isatty(2) Jeff King
2012-05-01 8:42 ` [PATCH 2/3] teach send-pack about --[no-]progress Jeff King
2012-05-01 8:43 ` [PATCH 3/3] t5541: test more combinations of --progress Jeff King
2012-05-01 9:35 ` Clemens Buchacher [this message]
2012-05-01 9:37 ` Jeff King
2012-05-01 17:53 ` David Ebbo
2012-05-01 20:45 ` Zbigniew Jędrzejewski-Szmek
2012-05-01 20:53 ` Junio C Hamano
2012-05-01 9:32 ` 1.7.10 doesn't show file pushstatus Clemens Buchacher
2012-05-01 17:33 ` Junio C Hamano
2012-05-02 1:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120501093501.GB22633@ecki.lan \
--to=drizzd@aon.at \
--cc=david.ebbo@gmail.com \
--cc=davidfowl@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=paul@github.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).