From: Jeff King <peff@peff.net>
To: Clemens Buchacher <drizzd@aon.at>
Cc: Junio C Hamano <gitster@pobox.com>, dfowler <davidfowl@gmail.com>,
git@vger.kernel.org, msysgit@googlegroups.com,
Paul Betts <paul@github.com>, David Ebbo <david.ebbo@gmail.com>
Subject: Re: [PATCH 3/3] t5541: test more combinations of --progress
Date: Tue, 1 May 2012 05:37:19 -0400 [thread overview]
Message-ID: <20120501093719.GA7538@sigill.intra.peff.net> (raw)
In-Reply-To: <20120501093501.GB22633@ecki.lan>
On Tue, May 01, 2012 at 11:35:01AM +0200, Clemens Buchacher wrote:
> Can we add this on top or squashed in? I regret using tee when I
> originally wrote the test.
>
> --8<--
> Subject: [PATCH] t5541: check return codes
>
> By piping output to tee, the return code of the command is hidden.
> Instead, redirect output to a file directly.
Ugh, absolutely. I blindly followed the existing style without thinking
about whether using tee was sane or not. And it's not. Thanks.
-Peff
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
next prev parent reply other threads:[~2012-05-01 9:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120501010609.GA14715@jupiter.local>
2012-05-01 6:58 ` 1.7.10 doesn't show file pushstatus Jeff King
2012-05-01 7:33 ` Jeff King
2012-05-01 8:40 ` Jeff King
2012-05-01 8:41 ` [PATCH 1/3] send-pack: show progress when isatty(2) Jeff King
2012-05-01 8:42 ` [PATCH 2/3] teach send-pack about --[no-]progress Jeff King
2012-05-01 8:43 ` [PATCH 3/3] t5541: test more combinations of --progress Jeff King
2012-05-01 9:35 ` Clemens Buchacher
2012-05-01 9:37 ` Jeff King [this message]
2012-05-01 17:53 ` David Ebbo
2012-05-01 20:45 ` Zbigniew Jędrzejewski-Szmek
2012-05-01 20:53 ` Junio C Hamano
2012-05-01 9:32 ` 1.7.10 doesn't show file pushstatus Clemens Buchacher
2012-05-01 17:33 ` Junio C Hamano
2012-05-02 1:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120501093719.GA7538@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=david.ebbo@gmail.com \
--cc=davidfowl@gmail.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=paul@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).