git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
	"Junio C Hamano" <gitster@pobox.com>,
	jnareb@gmail.com, git@vger.kernel.org
Subject: [PATCH] t/gitweb-lib: use $PERL_PATH to run gitweb
Date: Tue, 1 May 2012 13:55:00 -0400	[thread overview]
Message-ID: <20120501175500.GA24258@sigill.intra.peff.net> (raw)
In-Reply-To: <4FA02274.6070601@web.de>

The current code runs "perl gitweb.cgi" to test gitweb. This
will use whatever version of perl happens to be first in the
PATH. We are better off using the specific perl that the
user specified via PERL_PATH, which matches what gets put on
the #!-line of the built gitweb.cgi.

Signed-off-by: Jeff King <peff@peff.net>
---
On Tue, May 01, 2012 at 07:50:44PM +0200, Torsten Bögershausen wrote:

> > Torsten, does that fix your problem?
> Yes, it does.

OK, here it is with a commit message.

 t/gitweb-lib.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
index 21d11d6..ae2dc46 100644
--- a/t/gitweb-lib.sh
+++ b/t/gitweb-lib.sh
@@ -69,7 +69,7 @@ gitweb_run () {
 	# written to web server logs, so we are not interested in that:
 	# we are interested only in properly formatted errors/warnings
 	rm -f gitweb.log &&
-	perl -- "$SCRIPT_NAME" \
+	"$PERL_PATH" -- "$SCRIPT_NAME" \
 		>gitweb.output 2>gitweb.log &&
 	perl -w -e '
 		open O, ">gitweb.headers";
-- 
1.7.10.630.g31718

  parent reply	other threads:[~2012-05-01 17:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-01 11:23 [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin Torsten Bögershausen
2012-05-01 16:23 ` Zbigniew Jędrzejewski-Szmek
2012-05-01 16:34   ` Jeff King
2012-05-01 16:47   ` Junio C Hamano
2012-05-01 17:03     ` Zbigniew Jędrzejewski-Szmek
2012-05-01 17:08       ` Jeff King
2012-05-01 17:50         ` Torsten Bögershausen
2012-05-01 17:53           ` Junio C Hamano
2012-05-01 17:55           ` Jeff King [this message]
2012-05-01 20:18             ` [PATCH] Consistently use perl from /usr/bin/ for scripts Zbigniew Jędrzejewski-Szmek
2012-05-01 20:54               ` Randal L. Schwartz
2012-05-01 16:44 ` [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120501175500.GA24258@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=tboegi@web.de \
    --cc=zbyszek@in.waw.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).