* [PATCH 4/6] http: handle proxy authentication failure (error 407)
@ 2012-05-03 16:40 Nelson Benitez Leon
2012-05-04 7:23 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Nelson Benitez Leon @ 2012-05-03 16:40 UTC (permalink / raw)
To: git; +Cc: Jeff King
Handle http 407 error code by asking for credentials and
retrying request in case credentials were not present, or
marking credentials as rejected if they were already provided.
Signed-off-by: Nelson Benitez Leon <nbenitezl@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
http.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/http.c b/http.c
index 22ffe0c..c87c66c 100644
--- a/http.c
+++ b/http.c
@@ -879,6 +879,15 @@ static int http_request(const char *url, void *result, int target, int options)
init_curl_http_auth(slot->curl);
ret = HTTP_REAUTH;
}
+ } else if (results.http_code == 407) { /* Proxy authentication failure */
+ if (proxy_auth.username && proxy_auth.password) {
+ credential_reject(&proxy_auth);
+ ret = HTTP_NOAUTH;
+ } else {
+ credential_fill(&proxy_auth);
+ set_proxy_auth(slot->curl);
+ ret = HTTP_REAUTH;
+ }
} else {
if (!curl_errorstr[0])
strlcpy(curl_errorstr,
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/6] http: handle proxy authentication failure (error 407)
2012-05-03 16:40 [PATCH 4/6] http: handle proxy authentication failure (error 407) Nelson Benitez Leon
@ 2012-05-04 7:23 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2012-05-04 7:23 UTC (permalink / raw)
To: Nelson Benitez Leon; +Cc: git
On Thu, May 03, 2012 at 06:40:14PM +0200, Nelson Benitez Leon wrote:
> Handle http 407 error code by asking for credentials and
> retrying request in case credentials were not present, or
> marking credentials as rejected if they were already provided.
This one looks good to me.
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-04 7:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-03 16:40 [PATCH 4/6] http: handle proxy authentication failure (error 407) Nelson Benitez Leon
2012-05-04 7:23 ` Jeff King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).