From: Jeff King <peff@peff.net>
To: Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 5/6] http: Avoid limit of retrying request only twice
Date: Fri, 4 May 2012 03:24:27 -0400 [thread overview]
Message-ID: <20120504072427.GE21895@sigill.intra.peff.net> (raw)
In-Reply-To: <4FA2B4FC.3030309@seap.minhap.es>
On Thu, May 03, 2012 at 06:40:28PM +0200, Nelson Benitez Leon wrote:
> Current code, after receiving HTTP_REAUTH, only retried
> once, so couldn't do step 3 of the following sequence:
>
> 1. We make a request; proxy returns 407, because we didn't give it a
> password. We ask for the password and return HTTP_REAUTH.
>
> 2. We make another request; the proxy passes it to the actual server,
> who returns 401, because we didn't give an http password. We ask
> for the password and return HTTP_REAUTH.
>
> 3. We make a third request, but this time everybody is happy.
>
> Now we retry as long as we keep receiving HTTP_REAUTH, so the previous
> sequence correctly completes.
>
> Patch by Jeff King <peff@peff.net>
We usually spell that as:
From: Jeff King <peff@peff.net>
at the beginning of the email body (which lets am set the author
appropriately).
Other than that, the patch looks good to me (unsurprisingly :) ).
-Peff
next prev parent reply other threads:[~2012-05-04 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 16:40 [PATCH 5/6] http: Avoid limit of retrying request only twice Nelson Benitez Leon
2012-05-04 7:24 ` Jeff King [this message]
2012-05-04 10:20 ` Nelson Benitez Leon
2012-05-04 9:28 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504072427.GE21895@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nelsonjesus.benitez@seap.minhap.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).