From: Jeff King <peff@peff.net>
To: Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 5/6] http: Avoid limit of retrying request only twice
Date: Fri, 4 May 2012 05:28:15 -0400 [thread overview]
Message-ID: <20120504092814.GA24398@sigill.intra.peff.net> (raw)
In-Reply-To: <4FA3AD72.1010407@seap.minhap.es>
On Fri, May 04, 2012 at 12:20:34PM +0200, Nelson Benitez Leon wrote:
> On 05/04/2012 09:24 AM, Jeff King wrote:
> > On Thu, May 03, 2012 at 06:40:28PM +0200, Nelson Benitez Leon wrote:
> >
> >> [snip]
> >>
> >> Now we retry as long as we keep receiving HTTP_REAUTH, so the previous
> >> sequence correctly completes.
> >>
> >> Patch by Jeff King <peff@peff.net>
> >
> > We usually spell that as:
> >
> > From: Jeff King <peff@peff.net>
> >
> > at the beginning of the email body (which lets am set the author
> > appropriately).
>
> Are you saying the first line of the email body? isn't that for the
> commit message first-line? I suppose you're not refering to the 'from
> field' of the email as I would need alter identities in my email client
> and found that cumbersome. Sorry for me not getting it and asking for
> clarification.
Yes, that's what I am saying. When Junio applies the patch using "git
am", git will recognize these extra "pseudo-headers" at the top of the
body, remove them from the commit message, and override the email
headers with them.
It does this for exactly this case; you can leave your email headers
intact, but still provide attribution to someone else.
-Peff
prev parent reply other threads:[~2012-05-04 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 16:40 [PATCH 5/6] http: Avoid limit of retrying request only twice Nelson Benitez Leon
2012-05-04 7:24 ` Jeff King
2012-05-04 10:20 ` Nelson Benitez Leon
2012-05-04 9:28 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504092814.GA24398@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nelsonjesus.benitez@seap.minhap.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).