From: Jeff King <peff@peff.net>
To: Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/6] http: handle proxy proactive authentication
Date: Fri, 4 May 2012 06:51:07 -0400 [thread overview]
Message-ID: <20120504105106.GA24933@sigill.intra.peff.net> (raw)
In-Reply-To: <4FA3B92E.3000200@seap.minhap.es>
On Fri, May 04, 2012 at 01:10:38PM +0200, Nelson Benitez Leon wrote:
> > When you parse the URL via credential_from_url, the components you get
> > will have any URL-encoding removed. So when you regenerate the URL in
> > the proxyhost variable, you would need to re-encode.
>
> Can a hostname has url-encoded parts? I thought that was only for the
> request uri (/somedir/somefile.php) or the query string ('?var1=val'),
> I'm only using the hostname here as a proxy server never has more than
> that, apart from the port number.
Hmm. It can have URL-encoded parts (so we must decode when parsing), but
the more important question is whether the decoded version can have
parts that _need_ to be URL-encoded. And I think the answer is no,
after double-checking the RFCs (i.e., hostnames cannot contain any of the URL
reserved characters). So quoting would be a no-op, and we can skip it.
Anyway, your later patch ends up removing this chunk of code, so I think
we can forget the issue entirely.
-Peff
next prev parent reply other threads:[~2012-05-04 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 16:39 [PATCH 2/6] http: handle proxy proactive authentication Nelson Benitez Leon
2012-05-04 7:16 ` Jeff King
2012-05-04 11:10 ` Nelson Benitez Leon
2012-05-04 10:51 ` Jeff King [this message]
2012-05-04 13:55 ` Nelson Benitez Leon
2012-05-04 13:55 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504105106.GA24933@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nelsonjesus.benitez@seap.minhap.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).