From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Daniel Stenberg <daniel@haxx.se>,
Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>,
git@vger.kernel.org
Subject: Re: [PATCH 1/6] http: try http_proxy env var when http.proxy config option is not set
Date: Fri, 4 May 2012 12:05:43 -0400 [thread overview]
Message-ID: <20120504160543.GB1331@sigill.intra.peff.net> (raw)
In-Reply-To: <7v4nrwc61e.fsf@alter.siamese.dyndns.org>
On Fri, May 04, 2012 at 08:36:13AM -0700, Junio C Hamano wrote:
> Thanks for a nice summary, and I agree with your list of what we wish we
> had from the cURL library. With such a change, it becomes irrelevant how
> the user fed cURL provisional (partial) authentication information, either
> in http.proxy (which we turn into CURLOPT_PROXY), or from the environment
> (without Git having to know anything about it), and a lot of complexity
> that led to bugs in this series will become unnecessary.
>
> I am tempted to suggest that the current series should be rerolled without
> all the guessing and preauth tricks until such an update to the cURL
> library materializes.
I am very tempted by that, too. In the meantime (and even once that curl
version comes out and we write the new code, people will still be on the
older version of curl), we have a fallback: they can use http.proxy if
they want auth support. It's not as nice as supporting auth on the
environment variables, but I think it will end up being a lot cleaner.
-Peff
next prev parent reply other threads:[~2012-05-04 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 16:39 [PATCH 1/6] http: try http_proxy env var when http.proxy config option is not set Nelson Benitez Leon
2012-05-03 18:05 ` Junio C Hamano
2012-05-04 7:08 ` Jeff King
2012-05-04 7:27 ` Daniel Stenberg
2012-05-04 7:39 ` Jeff King
2012-05-04 15:12 ` Daniel Stenberg
2012-05-04 15:36 ` Junio C Hamano
2012-05-04 16:05 ` Jeff King [this message]
2012-05-04 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504160543.GB1331@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nelsonjesus.benitez@seap.minhap.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).