From: Pete Wyckoff <pw@padd.com>
To: Matthew Mendell <matthew.mendell@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git-p4: planned view wildcard support
Date: Mon, 7 May 2012 06:44:43 -0400 [thread overview]
Message-ID: <20120507104443.GA20372@padd.com> (raw)
In-Reply-To: <CAF0RQx-0M4iUHgGdH=RE_UFmLLZH8uy4kkMW=XspNzGm-vsyEg@mail.gmail.com>
matthew.mendell@gmail.com wrote on Sun, 06 May 2012 16:46 -0700:
> Is there any plan for the git-p4.py script to support the "*" wildcard
> in a p4 client?
>
> The specific test that exposes this unsupported feature:
> ./t9809-git-p4-client-view.sh
> ...
> ok 4 - unsupported view wildcard *
It hasn't been on anybody's priority list so far that I know, but
this would be not too hard to implement in theory.
The code changes would need to alter just one class. In
View.Path, functions Path.find_wildcards, match_wildcards and
fill_in_wildcards, if you're interested in giving it a try.
Can you constrain your use of "*" a bit? What makes these
wildcards difficult is all the edge cases. For instance, is
there ever more than one "*"? Is it combined with "..."? Are
there multiple lines in the client spec with wildcards? Some
abstracted examples would be interesting.
-- Pete
next prev parent reply other threads:[~2012-05-07 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-06 23:46 git-p4: planned view wildcard support Matthew Mendell
2012-05-07 10:44 ` Pete Wyckoff [this message]
2012-05-07 15:19 ` Matthew Mendell
2012-05-07 15:28 ` Pete Wyckoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507104443.GA20372@padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
--cc=matthew.mendell@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).