git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pete Wyckoff <pw@padd.com>
To: Luke Diamand <luke@diamand.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv1 0/3] git p4: tag import/export bug fixes
Date: Fri, 11 May 2012 06:21:43 -0400	[thread overview]
Message-ID: <20120511102143.GA2468@padd.com> (raw)
In-Reply-To: <1336717518-4214-1-git-send-email-luke@diamand.org>

luke@diamand.org wrote on Fri, 11 May 2012 07:25 +0100:
> This patch series fixes two bugs in my git p4 import/export code, and
> adds a test case for them.
> 
> Luke Diamand (3):
>   git p4: add test for tag import/export enabled via config
>   git p4: fix bug when verbose enabled with tag export
>   git p4: fix bug when enabling tag import/export via config variables
> 
>  git-p4.py                      |    6 +++---
>  t/t9811-git-p4-label-import.sh |   20 ++++++++++++++++++++
>  2 files changed, 23 insertions(+), 3 deletions(-)

These fixes look obviously good, and maint-worthy.  Ack.

		-- Pete

      parent reply	other threads:[~2012-05-11 10:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11  6:25 [PATCHv1 0/3] git p4: tag import/export bug fixes Luke Diamand
2012-05-11  6:25 ` [PATCHv1 1/3] git p4: add test for tag import/export enabled via config Luke Diamand
2012-05-11  6:25 ` [PATCHv1 2/3] git p4: fix bug when verbose enabled with tag export Luke Diamand
2012-05-11  6:25 ` [PATCHv1 3/3] git p4: fix bug when enabling tag import/export via config variables Luke Diamand
2012-05-11 10:21 ` Pete Wyckoff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120511102143.GA2468@padd.com \
    --to=pw@padd.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).