From: Jeff King <peff@peff.net>
To: Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] Reduced re-roll of http-proxy-more branch
Date: Fri, 11 May 2012 13:00:13 -0400 [thread overview]
Message-ID: <20120511170013.GA26916@sigill.intra.peff.net> (raw)
In-Reply-To: <4FAD1075.8020309@seap.minhap.es>
On Fri, May 11, 2012 at 03:13:25PM +0200, Nelson Benitez Leon wrote:
> Hi, based on last feedback by Junio and Jeff I've created this
> reduced version of http-proxy-more branch with all the bits
> about "reading proxy from environment" removed. When cURL adds
> the new api we will only need to expand the code introduced by
> commit 1/3 .
Thanks. I know it is frustrating to work on a series only to end up
discarding a big chunk of it. But I think the result here makes a lot
more sense in the long run.
Patches 2 and 3 look OK, but I have a few comments on the first one
(I'll reply separately).
-Peff
prev parent reply other threads:[~2012-05-11 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 13:13 [PATCH 0/3] Reduced re-roll of http-proxy-more branch Nelson Benitez Leon
2012-05-11 17:00 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511170013.GA26916@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nelsonjesus.benitez@seap.minhap.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).