git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] t/Makefile: retain cache t/.prove across prove runs
Date: Sat, 19 May 2012 11:27:12 -0400	[thread overview]
Message-ID: <20120519152711.GA6979@sigill.intra.peff.net> (raw)
In-Reply-To: <4FB7B429.80805@alum.mit.edu>

On Sat, May 19, 2012 at 04:54:33PM +0200, Michael Haggerty wrote:

> I totally believe you that some of the variations that I listed in my
> commentary don't work in the git context.  I'm not a prove expert; I
> just noticed that removing the .prove file is counterproductive and
> breaks some other prove features.  I also agree with you that it
> would be dangerous to encourage partial testing and that it is
> therefore not a priority to make the use case that you mentioned work
> in the git context.
> 
> I still think my patch makes sense.  The error that Peff pointed out
> was in my commentary, not in the patch itself or in the log message.
> Junio, is there something else keeping you from applying this patch?

Yeah, I hope my comments weren't interpreted as "don't apply this".
Keeping the .prove file around is a prerequisite for lots of clever
things, including some useful (--state=slow) and some less so
(--state=failed). But if the latter case does not work (if we even want
it to), it is because this patch is only the first building block. We
should definitely apply it.

-Peff

  reply	other threads:[~2012-05-19 15:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02 15:31 [PATCH] t/Makefile: retain cache t/.prove across prove runs mhagger
2012-05-02 16:07 ` Jeff King
2012-05-19 14:54   ` Michael Haggerty
2012-05-19 15:27     ` Jeff King [this message]
2012-05-20 21:18     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120519152711.GA6979@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mhagger@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).