From: Jonathan Nieder <jrnieder@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t3404: begin "exchange commits with -p" test with correct preconditions
Date: Sat, 19 May 2012 17:15:43 -0500 [thread overview]
Message-ID: <20120519221543.GE4567@burratino> (raw)
In-Reply-To: <4FB79CA8.7080103@kdbg.org>
Johannes Sixt wrote:
> The test case shows a bug in 'rebase -p', but even if the bug were fixed
> the test would fail because it did not ensure that the preconditions match
> the postconditions that were checked. Insert the suitable 'git checkout'.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> Could it be that this bug existed since the test case was introduced
> in cddb42d2?
Yeah, looks like it was always broken. I remember sanity checking
by removing the "-p", too, but that was probably before moving the
test to join the other -p tests. Thanks for fixing it.
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2012-05-19 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 13:14 [PATCH] t3404: begin "exchange commits with -p" test with correct preconditions Johannes Sixt
2012-05-19 22:15 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120519221543.GE4567@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).