From: Jeff King <peff@peff.net>
To: Bryan Turner <bturner@atlassian.com>
Cc: git@vger.kernel.org
Subject: Re: git rev-list %an, %ae, %at bug in v1.7.10.1 and beyond
Date: Tue, 22 May 2012 00:35:09 -0400 [thread overview]
Message-ID: <20120522043509.GB6859@sigill.intra.peff.net> (raw)
In-Reply-To: <20120522043221.GA6859@sigill.intra.peff.net>
On Tue, May 22, 2012 at 12:32:21AM -0400, Jeff King wrote:
> I'm not too surprised this is broken (in fact, I'm surprised it ever
> really worked). UTF-16, especially representing pure ascii characters,
> will have embedded NULs. Most of the code assumes that things like names
> and emails are NUL-terminated and ascii-compatible (so ascii, or some
> ascii-superset encoding like utf8, iso8859-1, etc). You can store a
> commit message (and name) in utf-16 if you tell git that you are doing
> so, but we should be re-encoding it before handling it.
Actually, I take that back. I think storing in utf-16 would probably
fail. We need to use ascii to even read the headers to get to the
encoding header to realize that it is in utf-16. So I believe we really
do only support ascii-superset encodings.
-Peff
next prev parent reply other threads:[~2012-05-22 4:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 8:01 git rev-list %an, %ae, %at bug in v1.7.10.1 and beyond Bryan Turner
2012-05-22 4:32 ` Jeff King
2012-05-22 4:35 ` Jeff King [this message]
2012-05-22 5:13 ` Bryan Turner
2012-05-22 5:58 ` Jeff King
2012-05-22 6:13 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120522043509.GB6859@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bturner@atlassian.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).