From: Jeff King <peff@peff.net>
To: Bryan Turner <bturner@atlassian.com>
Cc: git@vger.kernel.org
Subject: Re: git rev-list %an, %ae, %at bug in v1.7.10.1 and beyond
Date: Tue, 22 May 2012 02:13:28 -0400 [thread overview]
Message-ID: <20120522061328.GA17896@sigill.intra.peff.net> (raw)
In-Reply-To: <20120522055811.GA10597@sigill.intra.peff.net>
On Tue, May 22, 2012 at 01:58:11AM -0400, Jeff King wrote:
> $ git init
> $ echo content >foo && git add foo
> $ GIT_AUTHOR_NAME=a git commit -m msg
> Author: <>
> 1 file changed, 1 insertion(+)
> create mode 100644 foo
>
> Uh oh, that's odd. And worse:
>
> $ git log -1 --format='|%an <%ae>|'
> | <>|
>
> So there is definitely a bug. The unicode thing is a red herring, and if
> there was any unicode at some point, git stripped it out when making the
> commit. The real regression seems to be in single-character names.
>
> I'll see if I can find the bug.
Both are caused by an off-by-one error in split_ident_line. I just
posted a patch.
-Peff
prev parent reply other threads:[~2012-05-22 6:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 8:01 git rev-list %an, %ae, %at bug in v1.7.10.1 and beyond Bryan Turner
2012-05-22 4:32 ` Jeff King
2012-05-22 4:35 ` Jeff King
2012-05-22 5:13 ` Bryan Turner
2012-05-22 5:58 ` Jeff King
2012-05-22 6:13 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120522061328.GA17896@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bturner@atlassian.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).