git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Carsten Mattner <carstenmattner@googlemail.com>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] completion: rename _git and _gitk
Date: Tue, 22 May 2012 10:24:06 +0200	[thread overview]
Message-ID: <20120522082406.GA6001@goldbirke> (raw)
In-Reply-To: <1337395295-29162-2-git-send-email-felipe.contreras@gmail.com>

Hi,


On Sat, May 19, 2012 at 04:41:34AM +0200, Felipe Contreras wrote:
> Would be useful to provide backwards compatibility for _git. Also, zsh
> completion uses _git, and it cannot be changed.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  contrib/completion/git-completion.bash |   10 +++++-----
>  t/t9902-completion.sh                  |    2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index cd92322..3cb106e 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2597,7 +2597,7 @@ _git_whatchanged ()
>  	_git_log
>  }
>  
> -_git ()
> +_main_git ()

> -_gitk ()
> +_main_gitk ()

After all those namespace discussions the names of these functions
should start with _git or __git.


Gábor

  reply	other threads:[~2012-05-22  8:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-19  2:41 [PATCH 0/2] completion: backwards compatibility fix Felipe Contreras
2012-05-19  2:41 ` [PATCH 1/2] completion: rename _git and _gitk Felipe Contreras
2012-05-22  8:24   ` SZEDER Gábor [this message]
2012-05-22 18:00     ` Junio C Hamano
2012-05-22 18:52       ` Felipe Contreras
2012-05-19  2:41 ` [PATCH 2/2] completion: add support for backwards compatibility Felipe Contreras
2012-05-19  2:45 ` [PATCH 0/2] completion: backwards compatibility fix Jeff King
2012-05-19  7:54   ` Carsten Mattner
2012-05-19 15:31     ` Jeff King
2012-05-19 17:45       ` Carsten Mattner
2012-05-20  5:11 ` Junio C Hamano
2012-05-20  9:02 ` Carsten Mattner
2012-05-20 10:28   ` Felipe Contreras
2012-05-20 17:27     ` Carsten Mattner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120522082406.GA6001@goldbirke \
    --to=szeder@ira.uka.de \
    --cc=carstenmattner@googlemail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).