From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Samuel John <mail@samueljohn.de>, git@vger.kernel.org
Subject: Re: contrib/credential/osxkeychain: Makefile should allow to set CFLAGS
Date: Thu, 24 May 2012 13:51:43 -0400 [thread overview]
Message-ID: <20120524175143.GD3161@sigill.intra.peff.net> (raw)
In-Reply-To: <7vaa0xxz14.fsf@alter.siamese.dyndns.org>
On Thu, May 24, 2012 at 10:35:35AM -0700, Junio C Hamano wrote:
> > I think so. Why don't we do this?
>
> I am OK with that.
>
> CFLAGS/LDFLAGS that come from ../../../config.mak _might_ not be suitable
> for this binary, but I do not think of a concrete example how that could
> be. Besides, this is just an example in contrib/ so I'd not worry about
> it too much.
Yeah, I considered that, but I figured that what you have in config.mak
is _at least_ as sensible as the random defaults I stuck in the
Makefile. And overriding with "make CFLAGS=..." is still available.
-Peff
prev parent reply other threads:[~2012-05-24 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 20:25 contrib/credential/osxkeychain: Makefile should allow to set CFLAGS Samuel John
2012-05-22 21:00 ` Junio C Hamano
2012-05-23 17:36 ` Jeff King
2012-05-24 17:35 ` Junio C Hamano
2012-05-24 17:51 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524175143.GD3161@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mail@samueljohn.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).