From: Jeff King <peff@peff.net>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH WIP 0/3] top-level gitignore considered less harmful
Date: Sat, 26 May 2012 17:45:29 -0400 [thread overview]
Message-ID: <20120526214529.GA29463@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8Bbn3hSDC_LmFtOXfJZhV9SqStwSSXFwcQLjDyUUAjOpQ@mail.gmail.com>
On Sat, May 26, 2012 at 08:25:54PM +0700, Nguyen Thai Ngoc Duy wrote:
> On Sat, May 26, 2012 at 7:31 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> > The result is not so impressive (i'm on -O0 though). Old webkit.git,
> > before:
>
> (it's "git status" by the way)
>
> >
> > real 0m6.418s
> > user 0m5.561s
> > sys 0m0.827s
> >
> > after:
> >
> > real 0m5.262s
> > user 0m4.407s
> > sys 0m0.850s
>
> and with your patch to redistribute .gitignore in webkit, so top-level
> is small again:
>
> real 0m4.185s
> user 0m3.271s
> sys 0m0.905s
>
> so my numbers look "ok".
Is that last number just with the redistribution, or with the
redistribution _and_ your patch? I'd like to see both to see whether it
is the case that the two optimizations work together for combined
benefit, or if doing one makes the other one pointless.
-Peff
next prev parent reply other threads:[~2012-05-26 21:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 12:31 [PATCH WIP 0/3] top-level gitignore considered less harmful Nguyễn Thái Ngọc Duy
2012-05-26 12:31 ` [PATCH 1/3] Unindent excluded_from_list() Nguyễn Thái Ngọc Duy
2012-05-26 12:31 ` [PATCH 2/3] exclude: do strcmp as much as possible before fnmatch Nguyễn Thái Ngọc Duy
2012-05-27 6:51 ` Junio C Hamano
2012-05-27 12:06 ` Nguyen Thai Ngoc Duy
2012-05-27 18:14 ` Junio C Hamano
2012-05-28 1:03 ` Nguyen Thai Ngoc Duy
2012-05-28 5:02 ` Junio C Hamano
2012-05-29 18:03 ` Junio C Hamano
2012-05-29 18:21 ` Thiago Farina
2012-05-26 12:31 ` [PATCH 3/3] exclude: reduce computation cost on checking dirname in patterns Nguyễn Thái Ngọc Duy
2012-05-26 13:25 ` [PATCH WIP 0/3] top-level gitignore considered less harmful Nguyen Thai Ngoc Duy
2012-05-26 21:45 ` Jeff King [this message]
2012-05-27 3:45 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120526214529.GA29463@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).