Re: [PATCH] Remove perl dependency from git-submodule.sh

[Fredrik Gustafsson <iveqy@iveqy.com>]

On Thu, May 31, 2012 at 10:49:41AM -0700, Junio C Hamano wrote:
> Having said that, in the longer term, I think the right direction to
> go is the opposite.  It would be better to make "git-submodule.sh"
> work better with paths with funny characters in them, and one
> obvious approach is to read "ls-files -z" output with something
> capable of parsing NUL-terminated records, e.g. a Perl scriptlet.
> Adding a new shell loop like this patch only adds one place that
> needs to be fixed later when that happens, so I am not sure I like
> this patch.

Is perl really a dependency that git wants? Today only a few bit (often
non critical) are in perl. I thought the way was to get rid of those and
replace them with c? I'm very critical to dependencies when they are not needed.

I don't think forking for text-parsing when not needed is a good idea
either. Apart from the runtime issues, it makes the code harder to read.

With that said I do agree that funny path names should be supported and
maybe the correct solution is to make more use of perl and less of sh.
Mixing those, and doing it in the same file, I don't think is a good
idea.

Is the right direction to run a shellscript that invokes a
perl-scriptlet for textparsing?

-- 
Med vänliga hälsningar
Fredrik Gustafsson

tel: 0733-608274
e-post: iveqy@iveqy.com